https://flyte.org logo
Powered by
#contribute
Title
# contribute
g

Gopal Vashishtha

08/01/2023, 2:18 PM
I'd like to contribute a PR adding support for Azure sovereign clouds to your forked implementation of stow. Checks are passing, how can I get a reviewer?
k

Ketan (kumare3)

08/01/2023, 3:18 PM
Ohh please share a link to Pr here we can review
g

Gopal Vashishtha

08/01/2023, 3:24 PM
see above^
ping on this, just tested in my environment and this works well
k

Ketan (kumare3)

08/02/2023, 1:59 PM
Thank you @Gopal Vashishtha
Small request to add a test if you can if not just Ping me here - we can merge
g

Gopal Vashishtha

08/02/2023, 3:45 PM
Thanks for merging, Ketan! When should I expect the flyte Docker images to have this change included in them?
k

Ketan (kumare3)

08/02/2023, 3:50 PM
Cc @Eduardo Apolinario (eapolinario)
I think it might be on 1.9, do you mind updating it in some Flyte repos
e

Eduardo Apolinario (eapolinario)

08/02/2023, 4:53 PM
this is amazing, @Gopal Vashishtha. This can show up in the next Flyte release (1.9), but bringing the new version of stow has to be done manually, so can you open a few PRs in the downstream repos? (Basically flyteadmin, flytepropeller, and flyteplugins).
g

Gopal Vashishtha

08/03/2023, 12:12 AM
Yes happy to make the downstream PRs, do we need to cut a new release of stow first?
k

Ketan (kumare3)

08/03/2023, 1:52 AM
I cut one 0.37
g

Gopal Vashishtha

08/05/2023, 1:03 AM
bumping flytestdlib: https://github.com/flyteorg/flytestdlib/pull/162/files then will bump flyteadmin, flytepropeller, and datacatalog
@Eduardo Apolinario (eapolinario) thanks for merging! Can you also cut a release of flytestdlib sorry forgot to ask
e

Eduardo Apolinario (eapolinario)

08/05/2023, 1:10 AM
For sure, give me a min
actually, just wait a bit and we'll have a new version once https://github.com/flyteorg/flytestdlib/actions/runs/5767897828 finishes.
g

Gopal Vashishtha

08/05/2023, 1:21 AM
Can I get a reviewer for this follow-on PR? https://github.com/flyteorg/stow/pull/8 (createSignedUrl also needed this change)
OK so sadly even when I use the code in this PR, I get:
Copy code
HTTPSConnectionPool(host='flytedevmetadatastorage.blob.', port=443): Max retries exceeded with url: /tmp/flyte/development/H4R72TCNCSSLSRWAHH2XXHOBBI======/fast12e0966a09d853b92f9784cf3193c280.tar.gz?se=2023-08-16T01%3A26%3A01Z&sig=MwnihVTaj%2BopzMO3hs5b9DiwUwCLrufGZYxvjsjeQX4%3D&sp=aw&spr=https&sr=b&sv=2019-12-12 (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x145e3b970>: Failed to establish a new connection: [Errno 8] nodename nor servname provided, or not known'))
when calling 
pyflyte register
. Even though I'm specifying a base_url in both my ~/flyte/config.yml and in my flyte-binary configmap. As far as I can tell that means the Location being used to call CreateSignedUrl here is not getting passed the base_url parameter. CreateSignedUrl calls PreSignRequest using the container returned from getContainer. getContainer is using baseContainer. I tried passing in stowConfigOverride:
Copy code
storage:
        type: stow
        stow:
          kind: azure
          config:
            account: flytedevmetadatastorage
            base_url: <http://core.usgovcloudapi.net|core.usgovcloudapi.net>
            # You will need to pass in a "key" as well to auth
        signedUrl:
          stowConfigOverride:
            account: flytedevmetadatastorage
            base_url: <http://core.usgovcloudapi.net|core.usgovcloudapi.net>
but I get the same error. Any idea why my base URL is getting overriden with an empty string?
k

Ketan (kumare3)

08/16/2023, 3:51 AM
ohh this is interesting
would love to help here, but did you not add the base_url?
g

Gopal Vashishtha

08/16/2023, 4:50 PM
Ah yeah my question was more about why base_url wasn't being passed in. Figured it out and tested though, let me know if you can review @Ketan (kumare3) https://github.com/flyteorg/stow/pull/8/files
3 Views
Powered by