<https github com flyteorg flytekit releases tag v1 9 0a0|Re Flyte #flytekit

Join Slack

<Release - [Test/Alpha] Pydantic PR #1660> New rel...

# flytekit

acoustic-carpenter-78188

07/20/2023, 6:49 PM

Release - [Test/Alpha] Pydantic PR #1660 New release published by wild-endeavor #1660 flyteorg/flytekit

thankful-minister-83577

07/20/2023, 6:50 PM

@cool-lifeguard-49380 @loud-oil-9899 - this is the latest commit on that pr - 4c463dee4088e5e44dd1086cff6d7d2903df724d

thankful-minister-83577

07/20/2023, 6:50 PM

we can do more

cool-lifeguard-49380

07/20/2023, 7:18 PM

Cool thanks, will report back 👍

loud-oil-9899

07/20/2023, 7:21 PM

Thanks!

broad-monitor-993

07/20/2023, 7:56 PM

just for reference, this is what a v1 + v2-supported PR looks like: https://github.com/unionai-oss/pandera/pull/1253 (obviously the pydantic migration guide would probably be the best place to start)

agreeable-kitchen-44189

07/21/2023, 5:10 AM

Nice! I might go ahead and try this as well as we’re using pydantic for a lot of our internal models 👍

cool-lifeguard-49380

07/28/2023, 1:30 PM

Our integration tests failed when I removed our internal pydantic base model type transformer and replaced it with the alpha release. I boiled it down to this minimal example:

Copy code

from flytekit import task, workflow, dynamic

from pydantic import BaseModel


class Config(BaseModel):
    path: str


@task
def train(cfg: Config):
    print(cfg)


@dynamic(cache=True, cache_version="0.3")
def sub_wf(cfg: Config):
    train(cfg=cfg)


@workflow
def wf():
    sub_wf(cfg=Config(path="bar"))


if __name__ == "__main__":
    wf()

Upon local execution with

python test.py

, the error is:

Copy code

│ /home/fabiogratz/miniconda3/envs/dev/lib/python3.9/site-packages/flytekit/core/workflow.py:271 in __call__                  │
│                                                                                                                             │
│ ❱ 271 │   │   │   raise exc                                                                                                 │
│                                                                                                                             │
│ /home/fabiogratz/miniconda3/envs/dev/lib/python3.9/site-packages/flytekit/core/workflow.py:268 in __call__                  │
│                                                                                                                             │
│ ❱ 268 │   │   │   return flyte_entity_call_handler(self, *args, **input_kwargs)                                             │
│                                                                                                                             │
│ /home/fabiogratz/miniconda3/envs/dev/lib/python3.9/site-packages/flytekit/core/promise.py:1022 in flyte_entity_call_handler │
│                                                                                                                             │
│ ❱ 1022 │   │   │   result = cast(LocallyExecutable, entity).local_execute(child_ctx, **kwargs)                              │
│                                                                                                                             │
│ /home/fabiogratz/miniconda3/envs/dev/lib/python3.9/site-packages/flytekit/core/workflow.py:290 in local_execute             │
│                                                                                                                             │
│ ❱ 290 │   │   function_outputs = self.execute(**kwargs_literals)                                                            │
│                                                                                                                             │
│ /home/fabiogratz/miniconda3/envs/dev/lib/python3.9/site-packages/flytekit/core/workflow.py:729 in execute                   │
│                                                                                                                             │
│ ❱ 729 │   │   return exception_scopes.user_entry_point(self._workflow_function)(**kwargs)                                   │
│                                                                                                                             │
│ /home/fabiogratz/miniconda3/envs/dev/lib/python3.9/site-packages/flytekit/exceptions/scopes.py:203 in user_entry_point      │
│                                                                                                                             │
│ ❱ 203 │   │   │   │   raise type(exc)(f"Error encountered while executing '{fn_name}':\n  {exc                              │
╰─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
TypeError: Encountered error while executing workflow 'wf':
  Error encountered while executing 'wf':
  Parameter to MergeFrom() must be instance of same class: expected <class 'flyteidl.core.literals_pb2.Literal'> got <class 
'flyteidl.core.literals_pb2.LiteralMap'>.

👍 1

cool-lifeguard-49380

07/28/2023, 1:32 PM

When setting

cache=False

it works. But having forgotten to bump the cache version appears not to be the problem. When activating the cache and setting a cache version that 100% was never used before, it fails with this error on the first try.

cool-lifeguard-49380

07/28/2023, 1:32 PM

Can you pls take a look whether you can reproduce this error @loud-oil-9899?

loud-oil-9899

07/28/2023, 3:33 PM

thanks Fabio! I'll check it out

🙏 1

Open in Slack

Previous Next