https://flyte.org logo
#ask-the-community
Title
# ask-the-community
h

Hank Huang

07/14/2023, 5:01 PM
Hi community, anyone familiar with
pip-compile --resolver=backtracking <http://doc-requirements.in|doc-requirements.in>
? I am trying to add new third-party lib to flytekit, not sure what would the expected outcome would be? (what I get is a new requirement.txt, not sure if it sufficient enough) Thanks you!
y

Yee

07/14/2023, 9:54 PM
what are you trying to add?
the doc requirements is just for docs building, this is stuff like sphinx, etc.
flytekit core dependencies are defined in setup.py.
but we try to keep that small and are actually looking for ways to split out dependencies into optional subpackages.
h

Hank Huang

07/15/2023, 1:42 AM
Thanks @Yee for the response! I am import mashumaro to speed up the sterilize / de sterilize process. Here is the related PR(https://github.com/flyteorg/flytekit/pull/1735) The setup.py part is already set! But I found that there are many *requirement.txt need to add such information, that's why I try to add it through the pip-compile command. Looks like I have to do something else to achieve that, any good suggestions?
s

Samhita Alla

07/17/2023, 5:30 AM
I don't think you need to add mashmuro to docs requirements, @Hank Huang.
Thanks for contributing to flytekit, btw!
h

Hank Huang

07/17/2023, 6:41 AM
Hi @Samhita Alla, Thanks for the response! I see, Should I remove the part I added for requirements?
s

Samhita Alla

07/17/2023, 7:01 AM
The library's not needed in docs-requirements I believe.
h

Hank Huang

07/17/2023, 7:05 AM
I see, let me remove it! Thanks for your response!