Hi community I want to contribute to the flyteadmin reposito Flyte #flyte-support

Hi, community I want to contribute to the flyteadm...

damp-lion-88352

07/12/2023, 1:27 PM

Hi, community I want to contribute to the flyteadmin repository. I just clone the repo below and try to use the make file. https://github.com/flyteorg/flyteadmin And I face errors, can any maintainer update the dependency ?

Copy code

# Please make sure you have all the dependencies installed:
  $ make install
  
  # In case you are only missing goimports:
  $ go install <http://golang.org/x/tools/cmd/goimports@latest|golang.org/x/tools/cmd/goimports@latest>
  $ make goimports

These are my errors

Copy code

make install
Makefile:35: warning: overriding recipe for target 'k8s_integration_execute'
boilerplate/flyte/end2end/Makefile:12: warning: ignoring old recipe for target 'k8s_integration_execute'
make: Warning: File 'boilerplate/flyte/end2end/Makefile' has modification time 40363 s in the future
Using temp directory /tmp/gotooling-GgP
/tmp/gotooling-GgP /mnt/c/code/flyteadmin
Installing <http://github.com/EngHabu/mockery/cmd/mockery|github.com/EngHabu/mockery/cmd/mockery>
Installing <http://github.com/flyteorg/flytestdlib/cli/pflags@latest|github.com/flyteorg/flytestdlib/cli/pflags@latest>
package <http://github.com/flyteorg/flytestdlib/cli/pflags|github.com/flyteorg/flytestdlib/cli/pflags>
        imports <http://github.com/flyteorg/flytestdlib/cli/pflags/cmd|github.com/flyteorg/flytestdlib/cli/pflags/cmd>
        imports <http://github.com/flyteorg/flytestdlib/cli/pflags/api|github.com/flyteorg/flytestdlib/cli/pflags/api>
        imports <http://github.com/flyteorg/flytestdlib/storage|github.com/flyteorg/flytestdlib/storage>
        imports <http://github.com/flyteorg/stow/azure|github.com/flyteorg/stow/azure>
        imports <http://github.com/Azure/azure-sdk-for-go/sdk/storage/azblob|github.com/Azure/azure-sdk-for-go/sdk/storage/azblob>: build constraints exclude all Go files in /root/go/pkg/mod/github.com/!azure/azure-sdk-for-go/sdk/storage/azblob@v0.4.0
make: *** [boilerplate/flyte/golang_test_targets/Makefile:9: download_tooling] Error 1

Copy code

make goimports
Makefile:35: warning: overriding recipe for target 'k8s_integration_execute'
boilerplate/flyte/end2end/Makefile:12: warning: ignoring old recipe for target 'k8s_integration_execute'
make: Warning: File 'boilerplate/flyte/end2end/Makefile' has modification time 40569 s in the future
boilerplate/flyte/golang_test_targets/goimports: line 8: goimports: command not found
make: *** [boilerplate/flyte/golang_test_targets/Makefile:23: goimports] Error 127

damp-lion-88352

07/12/2023, 1:53 PM

I just found that https://github.com/Azure/go-autorest/tree/main/autorest/adal Azure just update the dependency. However, I am not familiar enough to solve the problem. If possible, please guide me how to develop and bulild my environment to develop this feature, thank you very much. https://github.com/flyteorg/flyte/issues/3847

damp-lion-88352

07/12/2023, 1:57 PM

Here writes the guide how to deal with the new issue, please help me. Thank you very much. https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azidentity/MIGRATION.md

glamorous-carpet-83516

07/12/2023, 6:19 PM

I think the doc is outdated. could you run make compile instead

damp-lion-88352

07/13/2023, 12:00 AM

it still doesn't work

Copy code

make compile
Makefile:35: warning: overriding recipe for target 'k8s_integration_execute'
boilerplate/flyte/end2end/Makefile:12: warning: ignoring old recipe for target 'k8s_integration_execute'
go build -o flyteadmin -ldflags="-s -w -X <http://github.com/flyteorg/flytestdlib/version.Version=05981db|github.com/flyteorg/flytestdlib/version.Version=05981db> -X <http://github.com/flyteorg/flytestdlib/version.Build=05981db|github.com/flyteorg/flytestdlib/version.Build=05981db> -X <http://github.com/flyteorg/flytestdlib/version.BuildTime=2023-07-13|github.com/flyteorg/flytestdlib/version.BuildTime=2023-07-13>" ./cmd/ && mv ./flyteadmin /bin
go: errors parsing go.mod:
/mnt/c/code/flyteadmin/go.mod:207: unknown directive: retract
make: *** [Makefile:39: compile] Error 1

I use go version go1.14 linux/amd64 Thank you very much

glamorous-carpet-83516

07/13/2023, 2:18 AM

you should use go 1.19

tall-lock-23197

07/13/2023, 5:22 AM

Here's the updated contribution guide, @damp-lion-88352: https://flyte--3811.org.readthedocs.build/en/3811/community/contribute.html#how-to-setup-dev-environment-for-f[…]opeller-datacatalog-and-flytestdlib

damp-lion-88352

07/13/2023, 8:13 AM

Thanks a lot, I will try it out today

Open in Slack

Previous Next