Channels
#ask-the-community
Title
# ask-the-community
l
L godlike
07/11/2023, 8:07 AMHi, community,
I've come across two different parameters both called "image_config" in different parts of the code. I'm a little bit confused about why they are not identical.
Should they represent the same use case, or do they have different purposes?
Here are the instances I am referring to:
Copy code
remote = FlyteRemote(config=Config.auto(), \
default_project="flytesnacks", default_domain="development")
execution = remote.execute(wf, \
inputs={"name": "Kermit"},\
image_config=ImageConfig("futureoutlier/flyte-practice:latest")) Copy code
flyte_workflow = remote.register_workflow(
entity=flyte_entity,
serialization_settings=SerializationSettings(
image_config=ImageConfig.from_images("futureoutlier/flyte-practice:latest"),
project="flytesnacks",
domain="development",
version="v1" # You need to specify the version here.
),
version="v1",
)k
Kevin Su
07/11/2023, 8:48 AMthe first example is outdated, could you help us update the doc?
l
L godlike
07/11/2023, 9:03 AMSure, no problem !
Hi kevin, I would love to help you update the doc.
But here's the problem.
The first example came from the comment in the code.
https://github.com/flyteorg/flytekit/blob/master/flytekit/configuration/__init__.py#L323C2-L339
It suggest users to use default image if there's no special requirement.
Should I modify the comment in the code?
y
Yee
07/11/2023, 4:03 PM
yes please
thank you.
the old type hints for
default_imageImageConfigl
L godlike
07/11/2023, 11:59 PMNo problem, I will do it today !
I've done both in flytesnacks and flytekit.
Please review it, thank you very much.
https://github.com/flyteorg/flytesnacks/pull/1024
https://github.com/flyteorg/flytekit/pull/1734