Join Slack
Powered by
<@USU6W5ATA> Curious if this implementation was in...
# flyte-support
l
lemon-gold-32767
07/10/2023, 2:37 AM
@glamorous-carpet-83516
Curious if this implementation was intentional?
https://github.com/flyteorg/flytekit/blob/db8fd39c8a2254897bc9f2fb9f1505e2e0268540/flytekit/image_spec/image_spec.py#L159-L160
Converting the hash object to string will include the memory address (which differs in every execution), so two identical requirements.txt file will have different hashes. I can submit pr if this is a bug. We just need to use hexdigest() instead of str() I think.
g
glamorous-carpet-83516
07/10/2023, 10:14 AM
good catch. that’s my bad. yup, create a pr if you get a chance, thanks.
👍 1
l
lemon-gold-32767
07/11/2023, 1:02 AM
https://github.com/flyteorg/flytekit/pull/1731
👍 1
2
Views
Open in Slack
Previous
Next