acoustic-carpenter-78188
07/07/2023, 4:51 PMpyflyte package and pyflyte register commands are inconsistent causing friction when using the pyflyte CLI. More specifically:
package command expects --pkgs <pkg> option , the <pkg> must be dot-delineated python packages. Example:
pyflyte --pkgs my.nested.workflow package
register command expects [PACKAGE_OR_MODULE] argument. The argument, even though it is called package or module, actually is a path. Example:
pyflyte register my/nested/worfklow
This inconsistency causes confusion, especially since the package command can be considered a subset of the register command.
Expected behavior
These 2 commands should expect consistent inputs argument/options.
In the register command:
• Add --pkgs option support which expect dot-delineated python packages.
• Either the existing`[PACKAGE_OR_MODULE]` or the --pkgs must be provided by user.
In the package command:
• Add [PACKAGE_OR_MODULE] supports which accept path to the workflow package
• Either [PACKAGE_OR_MODULE] or the --pkgs must be provided by user.
Hence, the following commands should be legal
pyflyte --pkgs my.nested.workflow package
pyflyte --pkgs my.nested.workflow register
pyflyte package my/nested/worfklow
pyflyte register my/nested/worfklow
Additional context to reproduce
No response
Screenshots
No response
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyte