#1707 Detect upstream nodes from container nested promises Pull request opened by wild-endeavor TL;DR Upstream nodes were not correctly being detected in cases where the inputs were behind a {} or a []. For example,

n1

here

def my_wf(a: int, b: str) -> (int, str):
    x, y = t1(a=a)
    d = t2(a={"key1": b, "key2": y})
    return x, d

would not have picked up

n0

as an upstream node because we weren't correctly traversing the structure. Found while implementing the now rejected generalized container types https://github.com/flyteorg/flytekit/pull/1700/files Type ☑︎ Bug Fix ☐ Feature ☐ Plugin Are all requirements met? ☑︎ Code completed ☑︎ Smoke tested ☑︎ Unit tests added ☐ Code documentation added ☐ Any pending items have an associated Issue Complete description Instead of iterating through the kwargs again, save nodes found while traversing the bindings from the promises. Also get rid of the mostly duplicate

binding_from_flyte_std

Tracking Issue NA flyteorg/flytekit ✅ All checks have passed 30/30 successful checks