Could we please make a 1.6.2 patch release contain...
# contributec
cool-lifeguard-49380
05/30/2023, 9:17 AMCould we please make a 1.6.2 patch release containing this fix?
I’d like to upgrade to 1.6 but can’t pip-compile flytekit and plugins in parallel from a pinned commit:
Copy code
ERROR: Cannot install flytekit 0.0.0+develop (from git+ssh://****@github.com/flyteorg/flytekit.git@f671fb68092979b0328b97453d0ba0d396a6398e) and <internal-package> (<internal-package>/pyproject.toml) because these package versions have conflicting dependencies.
The conflict is caused by:
The user requested flytekit 0.0.0+develop (from git+ssh://****@github.com/flyteorg/flytekit.git@f671fb68092979b0328b97453d0ba0d396a6398e)
flytekitplugins-deck-standard 0.0.0+develop depends on flytekit<2.0.0 and >=1.3.0b2cool-lifeguard-49380
05/30/2023, 9:20 AMI saw that theoretically I have the permissions to make releases in flytekit 🤔 I’m not sure if this is intended.
If you agree with making a 1.6.2 patch release for this fix and if it’s on purpose that I have the permission to publish releases, is it ok if I go ahead and create the release?
Also happy to wait for somebody else to do this though if its not on purpose for me to have the permissions.
g
glamorous-carpet-83516
05/30/2023, 1:42 PMyes, we can cut a release. cc @high-accountant-32689 @thankful-minister-83577
t
thankful-minister-83577
05/30/2023, 3:12 PM
yeah let’s do it please.
c
cool-lifeguard-49380
05/30/2023, 3:17 PMDo you want me to make the release or do you prefer doing it yourself @thankful-minister-83577 @high-accountant-32689? Both is 100% ok for me :)
t
thankful-minister-83577
05/30/2023, 3:17 PM
you do it
thankful-minister-83577
05/30/2023, 3:17 PM
please
thankful-minister-83577
05/30/2023, 3:17 PM
just generate the auto changelog too
c
cool-lifeguard-49380
05/30/2023, 3:23 PM👍 generated the auto changelog
cool-lifeguard-49380
05/30/2023, 3:24 PMt
thankful-minister-83577
05/30/2023, 3:28 PM
thanks!
🙏 1
c
cool-lifeguard-49380
05/30/2023, 3:30 PMThanks for confirming that I should go ahead and release. Will obviously not do so without explicitly checking in also in the future …
cool-lifeguard-49380
05/30/2023, 4:23 PMhave you seen this before?
https://github.com/flyteorg/flytekit/actions/runs/5123343274/jobs/9213772957
t
thankful-minister-83577
05/30/2023, 4:33 PM
re-running, should be fine.
👍 1
c
cool-lifeguard-49380
05/30/2023, 4:33 PMTriggered
cool-lifeguard-49380
05/30/2023, 4:45 PMDid fix it
🎉 2
👍 1
151 Views