#539 Use group attribute for KV version and add DB engine support Pull request opened by bimtauer TL;DR Removes the KV Version config parameter and instead uses the Secret

group

field to allow using both (and other Vault secret backends) dynamically. This also allows using the Database Secrets Engine, which effectively means noop since we want to read the whole credential and not just a specific key. Type ☐ Bug Fix ☑︎ Feature ☐ Plugin Are all requirements met? ☑︎ Code completed ☑︎ Smoke tested ☑︎ Unit tests added ☐ Code documentation added ☐ Any pending items have an associated Issue Complete description The Secret protobuf defines a group field which we have previously ignored. Leveraging that field allows to simplify the secret manager config and allows supporting multiple Vault secret backends dynamically by deciding what secret template to inject based on the optional

group

parameter. This is a breaking change for people using the previous version of the Vault Secret Manager. To migrate they will need to remove the

kvVersion

key from their propeller configs and specify the appropriate group version in their secret requests, like for example so:

@task(
    secret_requests=[
        Secret(group="foo", key="bar", group_version="kv2"),
    ]
)

Follow-up issue NA flyteorg/flytepropeller GitHub Actions: Build & Push Flytepropeller Image GitHub Actions: Goreleaser GitHub Actions: Bump Version ✅ 11 other checks have passed 11/14 successful checks