https://flyte.org logo
Powered by
#contribute
Title
# contribute
y

Yubo Wang

05/09/2023, 5:48 PM
hi team, I am trying to work on flyteconsole repo but had some troubles setting up my development environment following the contribution guide. Wonder if anyone can offer some guidance on the setup.
My first question is that, i had the dependencies installed https://github.com/flyteorg/flyteconsole/blob/master/CONTRIBUTING.md#-install-dependencies but visiting
Copy code
<http://localhost.different.admin.service.com:3000|localhost.different.admin.service.com:3000>
give me errors
k

Kevin Su

05/09/2023, 5:50 PM
What version of nodejs are you using?
y

Yubo Wang

05/09/2023, 5:51 PM
v16.19.0
also, should I run docker run sandbox first? but I am not sure which image version matches with the latest flyteconsole
Copy code
ERROR in ./src/client.tsx:4:21
  TS2307: Cannot find module '@flyteorg/common' or its corresponding type declarations.
      2 | import * as ReactDOM from 'react-dom';
      3 | import ReactGA from 'react-ga4';
    > 4 | import { env } from '@flyteorg/common';
        |                     ^^^^^^^^^^^^^^^^^^
      5 | import { App } from '@flyteorg/console';
      6 |
      7 | const WrappedApp = () => {

  ERROR in ./src/client.tsx:5:21
  TS2307: Cannot find module '@flyteorg/console' or its corresponding type declarations.
      3 | import ReactGA from 'react-ga4';
      4 | import { env } from '@flyteorg/common';
    > 5 | import { App } from '@flyteorg/console';
        |                     ^^^^^^^^^^^^^^^^^^^
      6 |
      7 | const WrappedApp = () => {
      8 |   return <App env={env} />;
error message
k

Kevin Su

05/09/2023, 5:53 PM
cc @Jason Porter
j

Jason Porter

05/09/2023, 6:01 PM
Ah yes, this is likely just a problem with our documentation; we'll update that. But I think for now all you need to do is run: 
yarn build:types
And then 
yarn install && yarn start
should work 👍
y

Yubo Wang

05/09/2023, 6:14 PM
thanks for the help @Jason Porter what is the docker image you use to spin up the dependencies of flyte?
I think 
docker run --rm --privileged -p 30080:30080 -p 30081:30081 -p 30082:30082 -p 30084:30084 <http://cr.flyte.org/flyteorg/flyte-sandbox|cr.flyte.org/flyteorg/flyte-sandbox>
This will complain there is no v1.9 something
b

Byron Hsu

05/09/2023, 6:38 PM
wow nice @Yubo Wang are you also going to work on the frontend part
y

Yubo Wang

05/09/2023, 6:41 PM
yeah, the union support on UI is missing. I think we need some knowledge on the frontend as well at Linkedin. We might need some customization in the future
@Kevin Su @Jason Porter still having trouble I have my local sandbox running fine on 
localhost:30080
I did 
export ADMIN_API_URL=<http://localhost:30080>
and 
DISABLE_AUTH=1
However, I am getting Failed to fetch data Network Error can you some help me with this? thanks
Screenshot 2023-05-09 at 1.56.09 PM.png
j

Jason Porter

05/09/2023, 11:55 PM
Interesting; would you be able to share your network tab (chrome devtools)?
y

Yubo Wang

05/10/2023, 12:05 AM
Screenshot 2023-05-09 at 5.05.39 PM.png
j

Jason Porter

05/10/2023, 12:09 AM
Are you getting a CORS error?
y

Yubo Wang

05/10/2023, 12:11 AM
yes actually
so I actually no longer need to work on the frontend for now. but would definitely want a clearer contributing doc if possible. The current one seems quite unorganized
4 Views
Powered by