#386 Refactor kf-operator plugins configs and support setting different specs for different replica groups
Pull request opened by
yubofredwang
TL;DR
This PR refactors config fields for kubeflow operator plugins including: TFJob, MPIJob, PyTorchJob. This change is
backward incompatible, so we will keep the original plugin configs untouched and use the new configs in v2 version of the plugins.
Type
☐ Bug Fix
☑︎ Feature
☐ Plugin
Are all requirements met?
☐ Code completed
☑︎ Smoke tested
☑︎ Unit tests added
☐ Code documentation added
☐ Any pending items have an associated Issue
Complete description
Code change includes:
1. Move TFJob, MPIJob, PyTorchJob from
flyteidl/plugins/
to
flyteidl/plugins/kubeflow/
2. Create
flyteidl/plugins/kubeflow/common.proto
that contains the definition RestartPolicy, RunPolicy and CleanPodPolicy
3. Add
xxxReplicaSpec
in each job type to allow settings of
replicas
,
image
,
resources
and
restart_policy
Tracking Issue
fixes
flyteorg/flyte#3308
Follow-up issue
flyteorg/flyteidl
✅ All checks have passed
13/13 successful checks