#333 Adding cleanupOnFailure to PhaseInfo Pull request opened by hamersaw TL;DR Adding a

cleanupOnFailure

field to the

PhaseInfo

reported by each task evaluation. This is useful to track situations where Flyte marks a task as

FAILED

but it should still be cleaned up during the workflow abort. An example is

ImagePullBackoff

where a k8s

Pod

requests an image that does not exist. Flyte will mark the

Pod

as a failure, but it is not cleaned up until the workflow CR is garbage collected. The `Pod`will continually reattempt to download the missing image (with backoff) maintaining it's hold on resources. Type ☑︎ Bug Fix ☐ Feature ☐ Plugin Are all requirements met? ☑︎ Code completed ☑︎ Smoke tested ☐ Unit tests added ☑︎ Code documentation added ☐ Any pending items have an associated Issue Complete description ^^^ Tracking Issue flyteorg/flyte#3239 Follow-up issue NA flyteorg/flyteplugins Codecov: 62.64% (-0.03%) compared to f5f4182 Codecov: 33.33% of diff hit (target 62.67%) ✅ 4 other checks have passed 4/6 successful checks