<#1595 Set default ComSpec when running on Windows...
# flyte-github
a
#1595 Set default ComSpec when running on Windows Pull request opened by pingsutw TL;DR Fixes below errors in the CI, The test is failing because the latest python requires user to set
COMSPEC
in environment variable. For more detail, check python/cpython#101283
Copy code
FAILED tests/flytekit/unit/extras/tasks/test_shell.py::test_shell_task_no_io - FileNotFoundError: shell not found: neither %ComSpec% nor %SystemRoot% is set
FAILED tests/flytekit/unit/extras/tasks/test_shell.py::test_input_substitution_primitive - FileNotFoundError: shell not found: neither %ComSpec% nor %SystemRoot% is set
FAILED tests/flytekit/unit/extras/tasks/test_shell.py::test_input_substitution_files - FileNotFoundError: shell not found: neither %ComSpec% nor %SystemRoot% is set
FAILED tests/flytekit/unit/extras/tasks/test_shell.py::test_input_substitution_files_ctx - FileNotFoundError: shell not found: neither %ComSpec% nor %SystemRoot% is set
FAILED tests/flytekit/unit/extras/tasks/test_shell.py::test_input_output_substitution_files - FileNotFoundError: shell not found: neither %ComSpec% nor %SystemRoot% is set
FAILED tests/flytekit/unit/extras/tasks/test_shell.py::test_input_single_output_substitution_files - FileNotFoundError: shell not found: neither %ComSpec% nor %SystemRoot% is set
FAILED tests/flytekit/unit/extras/tasks/test_shell.py::test_reuse_variables_for_both_inputs_and_outputs - FileNotFoundError: shell not found: neither %ComSpec% nor %SystemRoot% is set
FAILED tests/flytekit/unit/extras/tasks/test_shell.py::test_can_use_complex_types_for_inputs_to_f_string_template - FileNotFoundError: shell not found: neither %ComSpec% nor %SystemRoot% is set
Type ☐ Bug Fix ☐ Feature ☐ Plugin Are all requirements met? ☑︎ Code completed ☐ Smoke tested ☐ Unit tests added ☐ Code documentation added ☐ Any pending items have an associated Issue Complete description ^^^ Tracking Issue NA Follow-up issue NA flyteorg/flytekit All checks have passed 30/30 successful checks