I am submitting a <PR> to flyteconsole, but run in...
# contribute
m
I am submitting a PR to flyteconsole, but run into following error. Anyone has this issue before? The other PR didn’t have this though.
f
Is this in your fork?
Cc @brief-bird-56737 do you know
m
Yes, it’s in my fork
Should I use branch in the main repo instead?
Also, would like to get feedback on the changes itself.
f
cc @late-eye-50215 also fyi
l
Hey @most-gold-65483 - sorry for the lagged response; we've been heads down working on some features/bugs. But your PR looks good in general just give us a day or two to work with our UX/design team to think through some of the edge cases around archived launch plans and how/when we should surface them. But in general this looks great - and thanks! 🙌
🙏 1
Hey @most-gold-65483 - just wanted to let you know your changes were merged. Thanks! 🙌
m
Thanks a lot @late-eye-50215! I submitted several feature request to improve the Launch Plan UX in Flyte Console listed below. We want to understand if there is existing plan in Flyte roadmap which cater to this? We’d love to contribute to these. https://github.com/flyteorg/flyte/issues/3575 https://github.com/flyteorg/flyte/issues/3568 https://github.com/flyteorg/flyte/issues/3585
f
I think I love this idea, we will get back to you tomorrow
👍 1
Cc @broad-monitor-993 / @late-eye-50215 can either of you help drive this
b
@high-accountant-32689 @late-eye-50215 let’s discuss how these might fit into our roadmap
👍 2
152 Views