Hi team, I create two issues and prs inside for re...
# contributep
polite-ability-4005
04/03/2023, 5:09 PMHi team, I create two issues and prs inside for review:
1. [Core feature] Support horovod in mpi task cc: @glamorous-carpet-83516 @hallowed-mouse-14616
2. [Core feature] Add user id to security context cc @thankful-minister-83577 needs your pointer about the middleware
🙌 2
👀 1
polite-ability-4005
04/03/2023, 7:33 PMThanks @glamorous-carpet-83516 for the review.
Left a question https://github.com/flyteorg/flytekit/pull/1575/files#r1156378225
polite-ability-4005
04/03/2023, 8:35 PM@thankful-minister-83577 can you review the 2nd one when you get some time? thanks in advance
polite-ability-4005
04/04/2023, 5:44 AM@glamorous-carpet-83516 addressed the comment
👍 1
polite-ability-4005
05/02/2023, 5:06 AMhttps://github.com/flyteorg/flyteidl/pull/388
https://github.com/flyteorg/flyteadmin/pull/549/files
Addressed the comment and added e2e test for the user identifier
@thankful-minister-83577
polite-ability-4005
05/03/2023, 3:51 PM@agreeable-flower-8989
👀 1
a
agreeable-flower-8989
05/03/2023, 5:06 PMthanks Byron for the context here! So if i understand this correctly:
From UI, or flytekit you'll be able to add
user_identifieragreeable-flower-8989
05/03/2023, 5:07 PM(Would there be a change in console to show the user identity as well?)
p
polite-ability-4005
05/03/2023, 5:08 PMNo no
polite-ability-4005
05/03/2023, 5:09 PMQuick chat?
polite-ability-4005
05/03/2023, 5:09 PMUser_id will be parsed from oauth access token
151 Views