<#340 [BUG] The primaryContainerName of podtemplat...
# flyte-github
a
#340 [BUG] The primaryContainerName of podtemplate tasks is not overrode with kubeflow specific name Pull request opened by ByronHsu TL;DR Please replace this text with a description of what this PR accomplishes. The primaryContainerName of podtemplate tasks is not overrode with kubeflow specific name Type ☑︎ Bug Fix ☐ Feature ☐ Plugin Are all requirements met? ☑︎ Code completed ☐ Smoke tested ☐ Unit tests added ☐ Code documentation added ☐ Any pending items have an associated Issue Complete description In the previous implementation, we assumed all tasks are container task, so we used
taskCtx.TaskExecutionMetadata().GetTaskExecutionID().GetGeneratedName()
to get the primary container name. However, in the case of pod template, the primary container name can vary. The solution is to expose primaryContainerName from
ToK8sPodSpec
and pass to
OverridePrimaryContainerName
(which was named
OverrideDefaultContainerName)
. Tracking Issue flyteorg/flyte#3567 flyteorg/flyteplugins All checks have passed 6/6 successful checks