Mike Ossareh
03/27/2023, 5:15 PMflyte-binary
helm chart is there a way to specify which project's you'd like automatically defined? I'm looking for something like initialProjects
from the flyte-core
helm chartflyte-binary
helm chart which calls flyteadmin
in an initContainer
, but I'm working on the basis this wasn't ported to flyte-binary
for a reason?Samhita Alla
jeev
Yee
jeev
Yee
jeev
Yee
Mike Ossareh
03/28/2023, 4:18 PMYee
Mike Ossareh
03/28/2023, 4:18 PMYee
Mike Ossareh
03/28/2023, 4:19 PMjeev
Yee
Yee
jeev
Yee
jeev
Mike Ossareh
03/28/2023, 4:22 PMYee
Mike Ossareh
03/28/2023, 4:22 PMYee
Mike Ossareh
03/28/2023, 4:25 PMYee
Mike Ossareh
03/28/2023, 4:25 PMYee
Mike Ossareh
05/02/2023, 7:09 PMYee
jeev
Mike Ossareh
05/08/2023, 3:26 PMjeev
make helm
as far as the helm chart key goes: do we even need it? or can we just expose directly under the configuration
key? im not super opinionated on this. will defer to you and @Yee. everything else lgtm! thanks for the valuable contribution!Mike Ossareh
05/08/2023, 4:10 PMconfiguration.admin
• configuration.propeller
• configuration.dataCatalog
instead of configuration.flyte-binary.[admin,propeller,dataCatalog]
. I’m fine with this personally; it’s sort of the same thing from my POV 🙂 so I’m happy to do whatever you and @Yee suggest I do.jeev
flyte-binary
Mike Ossareh
05/09/2023, 3:11 AM000-core.yaml
already has a top level admin
entry
2. the args for flyte-binary
are in a Section
called flyte
a. we either change cmd/single/config.go
to use a different section name
b. or we accept that 000-core.yaml cannot have a top level admin
key and we put the flyte-binary args under flyte:
in the ConfgMap.
If the diff above is acceptable, I’ll cherry pick the commit onto the existing PR in the flyte repo - the PR above is just for demonstration purposes.Yee
jeev
Mike Ossareh
05/09/2023, 6:05 PM