<#383 Remove misleading token refresh logic from c...
# flyte-github
a
#383 Remove misleading token refresh logic from client credentials token source provider Pull request opened by andrewwdye TL;DR Removes unnecessary refresh logic from
ClientCredentialsTokenSourceProvider
and
customTokenSource
, as it's not supported by underlying client credentials token source. Type ☑︎ Bug Fix ☐ Feature ☐ Plugin Are all requirements met? ☑︎ Code completed ☑︎ Smoke tested ☑︎ Unit tests added ☐ Code documentation added ☐ Any pending items have an associated Issue Complete description Previously
customTokenSource
attempted to refresh near-expiration tokens; however, the underlying client credentials token source would always return the existing token, if valid. This change drops all of the refresh logic but maintains the token cache recently added to allow tokens to be reused across token providers, consistent with the interface used for other token providers. In effect the underlying client credentials token source cache is not used (queries should always require a new token). Tracking Issue NA Follow-up issue NA flyteorg/flyteidl Codecov: 76.11% (-0.61%) compared to bdb7630 12 other checks have passed 12/13 successful checks