<#422 [UI] Properly handle loading/error cases in ...
# flyte-github
a
#422 [UI] Properly handle loading/error cases in Launch form Issue created by schottra The Launch form was refactored to use a state machine and does not currently have any logic to show a loading indicator in cases where data takes more than 1 second to load. It also will not show any errors when data fails to load (other than logging to the browser console). This issue if for handling those two cases in the following scenarios: • Loading Task/Workflow versions for the selectors • Loading Launch Plans after selecting a workflow version • Loading inputs after selecting a Task Version or WorkflowVersion/Launch Plan combination Additionally, we may want to consider some logic for when we fail to load search results in the Workflow/Task version input. Some guidelines: • We have been slowly replacing circular progress indicators with
<Skeleton />
components where appropriate. This is probably one of those cases, as we don't want a succession of various loading indicators flashing into different spots in the form. • Loading indicators should only show if requests take longer than 1 second. • Errors should use a small or medium variant of the
DataError
component. flyteorg/flyteconsole