<#212 Fix dynamic workflows serialization> Pull re...
# flyte-github
a
#212 Fix dynamic workflows serialization Pull request opened by narape TL;DR Fix dynamic workflow task serialization. We broke dynamic workflows when we added strong types to workflows. Type ☑︎ Bug Fix ☐ Feature ☐ Plugin Are all requirements met? ☑︎ Code completed ☑︎ Smoke tested ☑︎ Unit tests added ☐ Code documentation added ☐ Any pending items have an associated Issue Complete description Dynamic workflows output a DynamicJobSpec that gets written in the propeller bucket as
futures.pb
, then propeller read this file and executes the workflow. The problem was that we changes how we register outputs with the strong types and this spec proto didn't contain the binding for the outputs, then the written file was missing this information and propeller failed and retried the task until the retry counts reach its limit, We didn't notice the breakage because we didn't contain unit tests for that (fixed) and the integration test was disabled (now enabled as well) Tracking Issue NA Follow-up issue NA flyteorg/flytekit-java ✅ All checks have passed 3/3 successful checks