GitHub
06/02/2023, 10:34 PMflyte:
admin:
seedProjects:
- name: myproject
description: My project description
Without Description
flyte:
admin:
seedProjects:
- koi
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
06/02/2023, 11:09 PMGitHub
06/02/2023, 11:09 PMGitHub
06/02/2023, 11:56 PMflyte
demo cluster
When I try to create a project from a file
Then it should be created in the demo
cluster
But it currently panics with an invalid memory address
> flytectl create project --file ./flyte/projects/myproject.yaml
INFO[0000] [0] Couldn't find a config file []. Relying on env vars and pflags.
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x147b463]
goroutine 1 [running]:
<http://github.com/flyteorg/flytectl/cmd/core.CommandContext.AdminClient(...)|github.com/flyteorg/flytectl/cmd/core.CommandContext.AdminClient(...)>
/home/runner/work/flytectl/flytectl/cmd/core/cmd_ctx.go:57
<http://github.com/flyteorg/flytectl/cmd/create.createProjectsCommand({0x2563718|github.com/flyteorg/flytectl/cmd/create.createProjectsCommand({0x2563718>, 0xc00005c228}, {0xc000ec5b40?, 0x100000049c165?, 0x25633c0?}, {0x0, {0x0, 0x0}, {0x0, 0x0}, ...})
/home/runner/work/flytectl/flytectl/cmd/create/project.go:62 +0xe3
<http://github.com/flyteorg/flytectl/cmd/core.generateCommandFunc.func1(0xc000af2f00|github.com/flyteorg/flytectl/cmd/core.generateCommandFunc.func1(0xc000af2f00>?, {0xc000a41620, 0x0, 0x2})
/home/runner/work/flytectl/flytectl/cmd/core/cmd.go:70 +0x93d
<http://github.com/spf13/cobra.(*Command).execute(0xc000af2f00|github.com/spf13/cobra.(*Command).execute(0xc000af2f00>, {0xc000a41600, 0x2, 0x2})
/home/runner/go/pkg/mod/github.com/spf13/cobra@v1.4.0/command.go:856 +0x67c
<http://github.com/spf13/cobra.(*Command).ExecuteC(0xc000a6e780)|github.com/spf13/cobra.(*Command).ExecuteC(0xc000a6e780)>
/home/runner/go/pkg/mod/github.com/spf13/cobra@v1.4.0/command.go:974 +0x3bd
<http://github.com/spf13/cobra.(*Command).Execute(...)|github.com/spf13/cobra.(*Command).Execute(...)>
/home/runner/go/pkg/mod/github.com/spf13/cobra@v1.4.0/command.go:902
<http://github.com/flyteorg/flytectl/cmd.ExecuteCmd()|github.com/flyteorg/flytectl/cmd.ExecuteCmd()>
/home/runner/work/flytectl/flytectl/cmd/root.go:137 +0x1e
main.main()
/home/runner/work/flytectl/flytectl/main.go:12 +0x1d
Expected behavior
A project to be created from the file
Additional context to reproduce
No response
Screenshots
No response
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
06/03/2023, 1:27 AMtyping.List
and can just use list
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
06/03/2023, 1:52 AMGitHub
06/03/2023, 4:46 AMuserflyterole
, is used.
Screenshot 2023-06-02 at 12 13 22 PM▾
Screenshot 2023-06-02 at 12 13 54 PM▾
GitHub
06/05/2023, 9:13 AMGitHub
06/05/2023, 9:38 AM<https://github.com/flyteorg/flytekit-java/tree/master|master>
by andresgomezfrr
<https://github.com/flyteorg/flytekit-java/commit/a165cf1d6d966563f832a241de8a02b6f3b61cd7|a165cf1d>
- Support converters to binding collection & maps (#226)
flyteorg/flytekit-javaGitHub
06/05/2023, 9:47 AM<https://github.com/flyteorg/flytekit-java/tree/master|master>
by github-actions[bot]
<https://github.com/flyteorg/flytekit-java/commit/35d6b75fb1d9722517b705cd1a269be8434e4c8c|35d6b75f>
- [maven-release-plugin] prepare release 0.4.17
flyteorg/flytekit-javaGitHub
06/05/2023, 9:47 AM<https://github.com/flyteorg/flytekit-java/tree/master|master>
by github-actions[bot]
<https://github.com/flyteorg/flytekit-java/commit/943ac342841d79eae38ad9e4d9895434eae53926|943ac342>
- [maven-release-plugin] prepare for next development iteration
flyteorg/flytekit-javaGitHub
06/05/2023, 11:07 AMtoJava()
of bindingCollection and bindingMap
Type
☑︎ Bug Fix
☐ Feature
☐ Plugin
Are all requirements met?
☐ Code completed
☐ Smoke tested
☑︎ Unit tests added
☐ Code documentation added
☐ Any pending items have an associated Issue
flyteorg/flytekit-java
✅ All checks have passed
3/3 successful checksGitHub
06/05/2023, 12:37 PM<https://github.com/flyteorg/flytekit-java/tree/master|master>
by andresgomezfrr
<https://github.com/flyteorg/flytekit-java/commit/342714b999bbc0b22be2d19eeaea61ea7d9866a5|342714b9>
- Support converters to binding collection & maps (toJava) (#227)
flyteorg/flytekit-javaGitHub
06/05/2023, 1:25 PM<https://github.com/flyteorg/flytekit-java/tree/master|master>
by andresgomezfrr
<https://github.com/flyteorg/flytekit-java/commit/510ec1a710be364dd1bc57c9f9e33ea2cc8e1f1a|510ec1a7>
- fix: upgrade com.google.errorprone:error_prone_annotations from 2.18.0 to 2.19.1 (#225)
flyteorg/flytekit-javaGitHub
06/05/2023, 1:25 PM<https://github.com/flyteorg/flytekit-java/tree/master|master>
by andresgomezfrr
<https://github.com/flyteorg/flytekit-java/commit/a5eb4f79955a56ae4324c836af8b7498131e80e5|a5eb4f79>
- fix: upgrade info.picocli:picocli from 4.7.1 to 4.7.2 (#224)
flyteorg/flytekit-javaGitHub
06/05/2023, 1:25 PMGitHub
06/05/2023, 1:25 PM<https://github.com/flyteorg/flytekit-java/tree/master|master>
by andresgomezfrr
<https://github.com/flyteorg/flytekit-java/commit/440047611c551451c626eaffd0f949f13ada8995|44004761>
- fix: upgrade com.google.api.grpc:proto-google-common-protos from 2.14.2 to 2.14.3 (#223)
flyteorg/flytekit-javaGitHub
06/05/2023, 1:25 PMGitHub
06/05/2023, 2:30 PMflytectl
does not support passing envs when creating executions, which pyflyte
does: flyteorg/flytekit#1617
Provide a possible output or UX example
Envs can be passed to flyteadmin when creating executions. This could either be achieved in the same as pyflyte
or utilizing flytectl
execution spec file.
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
06/05/2023, 2:34 PMflytectl
currently does not support passing envs to flyteadmin when creating executions. This PR adds the support by utilizing execution spec file.
Note that this works differently than pyflyte
, which is on one hand not ideal, but OTOH given the existence of execution spec file in flytectl
, using the file instead of a plain json string is less error prone and more traceable.
Tracking Issue
Closes flyteorg/flyte#3746
Follow-up issue
NA
flyteorg/flytectl
GitHub Actions: Goreleaser
GitHub Actions: Generate documentation
GitHub Actions: Bump Version
✅ 7 other checks have passed
7/10 successful checksGitHub
06/05/2023, 3:03 PM<https://github.com/flyteorg/flytekit-java/tree/master|master>
by github-actions[bot]
<https://github.com/flyteorg/flytekit-java/commit/5d953197da82c02d7c31adbfd3bb65f6d6919431|5d953197>
- [maven-release-plugin] prepare release 0.4.18
flyteorg/flytekit-javaGitHub
06/05/2023, 3:03 PM<https://github.com/flyteorg/flytekit-java/tree/master|master>
by github-actions[bot]
<https://github.com/flyteorg/flytekit-java/commit/8076468ed22180e75adef19da74769631b9ca6c7|8076468e>
- [maven-release-plugin] prepare for next development iteration
flyteorg/flytekit-javaGitHub
06/05/2023, 4:00 PM_InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
status = StatusCode.NOT_FOUND
details = "missing entity of type TASK with identifier project:"flytetester" domain:"development" name:"MAP_TASK_NAME" version:"VERSION" "
debug_error_string = "UNKNOWN:Error received from peer ipv4:10.34.2.243:443 {grpc_message:"missing entity of type TASK with identifier project:\"flytetester\" domain:\"development\" name:\"MAP_TASK_NAME\" version:\"VERSION\" ", grpc_status:5, created_time:"2023-06-02T15:32:48.383186-07:00"}"
>
Expected behavior
expect to be able to see the map_task tasks' info
Additional context to reproduce
task_execution = client.get_task_execution(flytekit.models.core.identifier.TaskExecutionIdentifier(
task_id=task_identifier,
node_execution_id=node_exe_identifier,
retry_attempt=0
))
flyte_task_exe = flytekit.remote.executions.FlyteTaskExecution.promote_from_model(task_execution)
remote.sync_task_execution(
execution=flyte_task_exe,
)
where task_identifier and node_exe_identifier is for the map_task
or call
synced = remote.sync(
execution=execution,
sync_nodes=True
)
on the workflow level.
Screenshots
No response
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
06/05/2023, 4:01 PMGitHub
06/05/2023, 4:01 PMGitHub
06/05/2023, 4:32 PM<https://github.com/flyteorg/flyteadmin/tree/master|master>
by EngHabu
<https://github.com/flyteorg/flyteadmin/commit/949f5a25e5f1fdca96e9908fde6506d1ff12a2b8|949f5a25>
- Add logs and stats to sync loop (#573)
flyteorg/flyteadminGitHub
06/05/2023, 5:16 PMGitHub
06/05/2023, 5:31 PMfrom __future__ import absolute_import, division, print_function
from typing import Optional
from flytekit import task, workflow, dynamic
from flytekit.types.file import FlyteFile
@task
def hello(myfile: Optional[FlyteFile]) -> Optional[FlyteFile]:
return None
@dynamic
def dyn_hello(myfile: Optional[FlyteFile]) -> Optional[FlyteFile]:
return hello(myfile=myfile)
@workflow
def child_workflow(myfile: Optional[FlyteFile]) -> Optional[FlyteFile]:
hello_output = dyn_hello(myfile=myfile)
return hello_output
when executed showing the following issue in FlytePropeller
E0601 21:21:14.327422 1 workers.go:102] error syncing 'flyte-sandbox/anwfrlcbl62scwxzsnh7': 0: [User] malformed dynamic workflow, caused by: Collected Errors: 2
Error 0: Code: MismatchingTypes, Node Id: end-node, Description: Variable [o1] (type [union_type:<variants:<blob:<> structure:<tag:"FlyteFilePath" > > variants:<simple:NONE structure:<tag:"none" > > > ]) doesn't match expected type [union_type:<variants:<blob:<> > variants:<simple:NONE > > ].
Error 1: Code: ParameterNotBound, Node Id: end-node, Description: Parameter not bound [o1].
Flytekit version: v1.4
Flytepropeller version: v1.1.91
Expected behavior
Optional output type is correctly transformed and routed to downstream tasks or returned.
relevant slack conversation is here https://flyte-org.slack.com/archives/CP2HDHKE1/p1685654534312309
Additional context to reproduce
Register and run the example workflow described above in sandbox.
Screenshots
No response
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
06/05/2023, 6:26 PM<https://github.com/flyteorg/flytectl/tree/master|master>
by eapolinario
<https://github.com/flyteorg/flytectl/commit/0cb2bfaf436a09d58c1ae9c1389eacb6eab8a856|0cb2bfaf>
- Support envs when creating execution (#408)
flyteorg/flytectlGitHub
06/05/2023, 6:41 PM