GitHub
05/27/2023, 12:19 PMGitHub
05/28/2023, 4:01 AMflytectl demo start --pre
, the correct behavior should be to choose the latest version, regardless of whether it corresponds to a pre-release.
Type
☑︎ Bug Fix
☐ Feature
☐ Plugin
Are all requirements met?
☑︎ Code completed
☑︎ Smoke tested
☐ Unit tests added
☐ Code documentation added
☐ Any pending items have an associated Issue
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/
flyteorg/flytectl
GitHub Actions: Goreleaser
GitHub Actions: Generate documentation
GitHub Actions: Bump Version
✅ 9 other checks have passed
9/12 successful checksGitHub
05/28/2023, 4:20 AM<https://github.com/flyteorg/flytectl/tree/master|master>
by jeevb
<https://github.com/flyteorg/flytectl/commit/e5e63bad2cc60e8da79523f3aca272b16dc792a3|e5e63bad>
- When preleases are allowed for demo sandbox, simply choose the latest release (#407)
flyteorg/flytectlGitHub
05/28/2023, 4:46 AMGitHub
05/28/2023, 4:46 AM<https://github.com/flyteorg/homebrew-tap/tree/main|main>
by flyte-bot
<https://github.com/flyteorg/homebrew-tap/commit/481c031aaba67d86540ef0a2a17241451c1f3aa4|481c031a>
- Brew formula update for flytectl version v0.6.38
flyteorg/homebrew-tapGitHub
05/28/2023, 5:52 PMTypeTransformer
. This PR alters that behavior to anywhere `TypeTransformer`s are used.
Type
☐ Bug Fix
• [X ] Feature
☐ Plugin
Are all requirements met?
☐ Code completed
☐ Smoke tested
☐ Unit tests added
☐ Code documentation added
☐ Any pending items have an associated Issue
Complete description
The special casing for pickling as a serialization/deserialization method leads to some strange behavior where, e.g
@task
def my_task(foo: Foo):
...
Is valid, because that type is manually converted, but e.g. or Foo
inside of a dataclass etc are not. Because the conversion to the placeholder FlytePickle
type happens in a function which is only called once on top level type, and only traverses the origin
stack, rather than being used anywhere TypeTransformers
are used. This PR fixes that problem.
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/
flyteorg/flytekit
DCO: DCO
✅ 1 other check has passed
1/2 successful checksGitHub
05/28/2023, 7:29 PMmake generate
, and add it back.
Type
☑︎ Bug Fix
☐ Feature
☐ Plugin
Are all requirements met?
☐ Code completed
☐ Smoke tested
☐ Unit tests added
☐ Code documentation added
☐ Any pending items have an associated Issue
flyteorg/flyteidl
✅ All checks have passed
13/13 successful checksGitHub
05/28/2023, 7:57 PMGitHub
05/29/2023, 4:05 AMGitHub
05/29/2023, 10:38 AM<https://github.com/flyteorg/flyte/tree/master|master>
by davidmirror-ops
<https://github.com/flyteorg/flyte/commit/baba9bd59008d640c10344906c11473b1cfb166e|baba9bd5>
- Update community page (#3700)
flyteorg/flyteGitHub
05/29/2023, 4:00 PMGitHub
05/29/2023, 8:23 PMpyflyte -c cfg.yaml package ...
, if a user has Config.auto()
in their code, cfg.yaml
should get used.
Type
☑︎ Bug Fix
☐ Feature
☐ Plugin
Are all requirements met?
☑︎ Code completed
☑︎ Smoke tested
☐ Unit tests added
☐ Code documentation added
☐ Any pending items have an associated Issue
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/
flyteorg/flytekit
Codecov: 71.01% (-0.02%) compared to f671fb6
Codecov: 53.84% of diff hit (target 71.03%)
✅ 28 other checks have passed
28/30 successful checksGitHub
05/30/2023, 3:23 PMGitHub
05/30/2023, 3:51 PMManagedCertificate
in combination with the GKE ingress controller as well as the use of cert manager with the nginx ingress controller.
However, when using the GCP ingress, the flyteadmin
backend will always be shown as unhealthy (even though it isn't) as the GKE ingress controller cannot interpret probes of type exec.command
which flyteadmin uses and which are recommended for gRPC services. Instead, the GKE ingress would need to either get a path + port where the app returns 200 if it is healthy or it needs to be given a TCP port where it will try to open a socket. (The way the GKE ingress checks for health can be customized with a so-called backend config. (In the Flyte Slack, users have reported that they used this mechanism to fix the broken health check.)
The documentation should either provide instructions for using the GKE ingress controller that work out of the box or remove references to it and instead only recommend the nginx ingress controller.
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
05/30/2023, 5:46 PMGitHub
05/30/2023, 5:48 PMpyflyte init
, and instead uses gitpython, without templating.
This is part of a wider effort to replace our Dockerfile / docker_build.sh systems with the much simpler ImageSpec
.
This PR depends on flyteorg/flytekit-python-template#40
This is a breaking change
All templates are now imagespec based, and cookiecutter is no longer used to generate custom readme titles or directory names.
Type
☐ Bug Fix
☑︎ Feature
☐ Plugin
Are all requirements met?
☑︎ Code completed
☑︎ Smoke tested
☐ Unit tests added
☑︎ Code documentation added
☐ Any pending items have an associated Issue
Complete description
As discussed as part of the larger Flyte example improvement with newly introduced imagespec.
flyteorg/flytekit
GitHub Actions: build-plugins (3.11, flytekit-bigquery)
✅ 29 other checks have passed
29/30 successful checksGitHub
05/30/2023, 6:15 PM<https://github.com/flyteorg/flyteidl/tree/master|master>
by pingsutw
<https://github.com/flyteorg/flyteidl/commit/e718afd9db4862275acd58ca3faaa062442130db|e718afd9>
- Rename externalPluginService to AgentService (#410)
flyteorg/flyteidlGitHub
05/30/2023, 6:20 PMGitHub
05/30/2023, 7:34 PMGitHub
05/30/2023, 8:26 PM<https://github.com/flyteorg/flyteadmin/tree/master|master>
by katrogan
<https://github.com/flyteorg/flyteadmin/commit/3379031b05bec09df6b7bb1bd99d499cf900b268|3379031b>
- Fix utf-8 encoding issues with trimmed error messages (#569)
flyteorg/flyteadminGitHub
05/30/2023, 9:22 PMGitHub
05/30/2023, 10:40 PMGitHub
05/30/2023, 10:43 PMGitHub
05/30/2023, 10:58 PM@task
def nested_task() -> int:
return 42
@task
def t1() -> int:
return nested_task()
@workflow
def wf() -> int:
return t1()
nested_task
runs in the same process as task
, as though it was a local execution of that task.
Expected behavior
Users should receive some indication that nested tasks are not allowed. A log message should suffice.
Maybe worth calling out in the documentation as well.
Additional context to reproduce
No response
Screenshots
No response
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
05/30/2023, 10:59 PMGitHub
05/31/2023, 2:35 AMpackage.json
preventing build.
Type
☐ Bug Fix
☐ Feature
☐ Plugin
Are all requirements met?
☐ Code completed
☐ Smoke tested
☐ Unit tests added
☐ Code documentation added
☐ Any pending items have an associated Issue
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/
flyteorg/flyteconsole
Codecov: 0.00% of diff hit (target 65.84%)
GitHub Actions: Build & Push FlyteConsole Image
GitHub Actions: Get Release Tag
GitHub Actions: Generate Release
✅ 7 other checks have passed
7/11 successful checksGitHub
05/31/2023, 4:16 AM<https://github.com/flyteorg/flyteconsole/tree/master|master>
by jsonporter
<https://github.com/flyteorg/flyteconsole/commit/3184646c7d24445cd5484be0d44fa0c86bb10906|3184646c>
- fix: navlink (#772)
flyteorg/flyteconsoleGitHub
05/31/2023, 4:28 AMGitHub
05/31/2023, 5:11 AMGitHub
05/31/2023, 7:41 AM