GitHub
04/17/2023, 4:12 PM<https://github.com/flyteorg/flytepropeller/tree/master|master>
by hamersaw
<https://github.com/flyteorg/flytepropeller/commit/e4ca252977fe791946e70e79d645658025f3d2af|e4ca2529>
- Setting primaryContainerName by default on Pod plugin (#555)
flyteorg/flytepropellerGitHub
04/17/2023, 4:54 PMGitHub
04/17/2023, 7:02 PMpartial
to provide default arguments to tasks. The flytesnacks documentation should be updated with this information in the basics section and maybe also the Flyte Fundamentals section
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
04/17/2023, 9:11 PMproject.yaml
file as documented in the flytectl helpstring: https://docs.flyte.org/projects/flytectl/en/latest/gen/flytectl_update_project.html#id1
The state doesn't actually get respected but gets overridden by the default config value (which is to set the project to active)
Expected behavior
Project state defined in a yaml spec should be respected when using flytectl to update a project
Additional context to reproduce
No response
Screenshots
No response
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
04/17/2023, 9:19 PMstate: 1
and then state: 0
in project.yaml and verified the project was archived and activated as expected (see https://github.com/flyteorg/flyteidl/blob/master/protos/flyteidl/admin/project.proto#L37,L45 for enum values)
• Also used command line flags flytectl update project -p flytetester --archiveProject
and then flytectl update project -p flytetester --activate
to verify the project archived and activated as expected
Tracking Issue
flyteorg/flyte#3605
Follow-up issue
NA
flyteorg/flytectl
GitHub Actions: Goreleaser
GitHub Actions: Generate documentation
GitHub Actions: Bump Version
GitHub Actions: Unit Tests / Run Unit Test
✅ 6 other checks have passed
6/10 successful checksGitHub
04/17/2023, 9:38 PMCOMSPEC
in environment variable.
For more detail, check python/cpython#101283
FAILED tests/flytekit/unit/extras/tasks/test_shell.py::test_shell_task_no_io - FileNotFoundError: shell not found: neither %ComSpec% nor %SystemRoot% is set
FAILED tests/flytekit/unit/extras/tasks/test_shell.py::test_input_substitution_primitive - FileNotFoundError: shell not found: neither %ComSpec% nor %SystemRoot% is set
FAILED tests/flytekit/unit/extras/tasks/test_shell.py::test_input_substitution_files - FileNotFoundError: shell not found: neither %ComSpec% nor %SystemRoot% is set
FAILED tests/flytekit/unit/extras/tasks/test_shell.py::test_input_substitution_files_ctx - FileNotFoundError: shell not found: neither %ComSpec% nor %SystemRoot% is set
FAILED tests/flytekit/unit/extras/tasks/test_shell.py::test_input_output_substitution_files - FileNotFoundError: shell not found: neither %ComSpec% nor %SystemRoot% is set
FAILED tests/flytekit/unit/extras/tasks/test_shell.py::test_input_single_output_substitution_files - FileNotFoundError: shell not found: neither %ComSpec% nor %SystemRoot% is set
FAILED tests/flytekit/unit/extras/tasks/test_shell.py::test_reuse_variables_for_both_inputs_and_outputs - FileNotFoundError: shell not found: neither %ComSpec% nor %SystemRoot% is set
FAILED tests/flytekit/unit/extras/tasks/test_shell.py::test_can_use_complex_types_for_inputs_to_f_string_template - FileNotFoundError: shell not found: neither %ComSpec% nor %SystemRoot% is set
Type
☐ Bug Fix
☐ Feature
☐ Plugin
Are all requirements met?
☑︎ Code completed
☐ Smoke tested
☐ Unit tests added
☐ Code documentation added
☐ Any pending items have an associated Issue
Complete description
^^^
Tracking Issue
NA
Follow-up issue
NA
flyteorg/flytekit
✅ All checks have passed
30/30 successful checksGitHub
04/17/2023, 10:17 PM<https://github.com/flyteorg/flytectl/tree/master|master>
by katrogan
<https://github.com/flyteorg/flytectl/commit/bd6b85605f49ff4877484edd69942ca72f4e19dd|bd6b8560>
- Respect project state in project.yaml file (#402)
flyteorg/flytectlGitHub
04/17/2023, 10:33 PM<https://github.com/flyteorg/flyteconsole/tree/master|master>
by jsonporter
<https://github.com/flyteorg/flyteconsole/commit/27238ced4679266c7bbf8c409fdcc21721802841|27238ced>
- fix: force node executions to pull their status (#737)
flyteorg/flyteconsoleGitHub
04/17/2023, 10:47 PM<https://github.com/flyteorg/flytekit/tree/master|master>
by pingsutw
<https://github.com/flyteorg/flytekit/commit/401c505ecb511aad6dba70adcae50762b4288521|401c505e>
- Add support nested FlyteFile in pyflyte run (#1587)
flyteorg/flytekitGitHub
04/17/2023, 10:57 PMGitHub
04/17/2023, 10:57 PM<https://github.com/flyteorg/homebrew-tap/tree/main|main>
by flyte-bot
<https://github.com/flyteorg/homebrew-tap/commit/df4e84ccb2843d1af91314a1090e72893d904594|df4e84cc>
- Brew formula update for flytectl version v0.6.36
flyteorg/homebrew-tapGitHub
04/17/2023, 11:11 PMGitHub
04/17/2023, 11:59 PMRuntimeError
, the workflow is retried. According to the docs, it seems like this case is considered non-recoverable and should not be retried.
Expected behavior
Workflow and task fail with no retries
Additional context to reproduce
No response
Screenshots
Traceback (most recent call last):
File "/app/pip_pypi__flytekit/flytekit/exceptions/scopes.py", line 203, in user_entry_point
return wrapped(*args, **kwargs)
File "/app/atomwise/...", line 266, in run_block
block.validate_output(cmpds, result)
File "/app/atomwise/..., line 119, in validate_output
raise RuntimeError(
Message:
<blah>
User error.
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
04/18/2023, 12:21 AM<https://github.com/flyteorg/flytekit/tree/master|master>
by eapolinario
<https://github.com/flyteorg/flytekit/commit/b721b5772dddcccdd22c1a60268172fac1312ca4|b721b577>
- Set cache_regions=True in the case of s3fs (#1592)
flyteorg/flytekitGitHub
04/18/2023, 12:39 AM$ docker run -it --platform linux/arm64 -u root <http://cr.flyte.org/flyteorg/flyteadmin-release:latest|cr.flyte.org/flyteorg/flyteadmin-release:latest> sh
/ # apk add file
/ # file bin/flyteadmin
bin/flyteadmin: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=pwwxVfCtJjTsZm9XA0ED/BJdCEuBm0QjhMujOZ7E7/a_vHl8mBZ4xrHPFYqAdf/on6kzeFZfsYdRjhPjzhK, stripped
Other images also have this issue, for example:
$ docker run -it --platform linux/arm64 -u root <http://cr.flyte.org/flyteorg/datacatalog:latest|cr.flyte.org/flyteorg/datacatalog:latest> sh
/ # apk add file
/ # file bin/datacatalog
bin/datacatalog: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=YBzDJD8nguzh9dRW4GPp/iKNJqrMQzbqKL7lVR_L0/_wLIwVTI2EO3sXJO2Sup/5m-2xGfqxh4rTZlXehX4, not stripped
I did not check every images, but I'm pretty sure that most images have the issue.
Expected behavior
ARM64 Docker Images should not contain x86_64 binaries. They should contain arm64 binaries instead. Graviton instances should be able to run flyte using docker.
Additional context to reproduce
No response
Screenshots
No response
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
04/18/2023, 1:12 AMimage▾
GitHub
04/18/2023, 2:36 AM<https://github.com/flyteorg/flytekit/tree/master|master>
by pingsutw
<https://github.com/flyteorg/flytekit/commit/f83e4b366ae03b2ed087cb22f868ba27e7639c3a|f83e4b36>
- Set default ComSpec when running on Windows (#1595)
flyteorg/flytekitGitHub
04/18/2023, 1:58 PMcleanupOnFailure
field to the PhaseInfo
reported by each task evaluation. This is useful to track situations where Flyte marks a task as FAILED
but it should still be cleaned up during the workflow abort. An example is ImagePullBackoff
where a k8s Pod
requests an image that does not exist. Flyte will mark the Pod
as a failure, but it is not cleaned up until the workflow CR is garbage collected. The `Pod`will continually reattempt to download the missing image (with backoff) maintaining it's hold on resources.
Type
☑︎ Bug Fix
☐ Feature
☐ Plugin
Are all requirements met?
☑︎ Code completed
☑︎ Smoke tested
☐ Unit tests added
☑︎ Code documentation added
☐ Any pending items have an associated Issue
Complete description
^^^
Tracking Issue
flyteorg/flyte#3239
Follow-up issue
NA
flyteorg/flyteplugins
Codecov: 62.64% (-0.03%) compared to f5f4182
Codecov: 33.33% of diff hit (target 62.67%)
✅ 4 other checks have passed
4/6 successful checksGitHub
04/18/2023, 4:11 PMInterruptible
and OverwriteCache
flags should be maintained through the ExecutionSpec
when running reference launchplans in from a workflow.
Type
☑︎ Bug Fix
☐ Feature
☐ Plugin
Are all requirements met?
☑︎ Code completed
☑︎ Smoke tested
☐ Unit tests added
☑︎ Code documentation added
☐ Any pending items have an associated Issue
Complete description
^^^
Tracking Issue
fixes flyteorg/flyte#3550
Follow-up issue
NA
flyteorg/flytepropeller
GitHub Actions: Build & Push Flytepropeller Image
GitHub Actions: Goreleaser
GitHub Actions: Bump Version
✅ 11 other checks have passed
11/14 successful checksGitHub
04/18/2023, 5:59 PMGitHub
04/18/2023, 7:12 PMTaskResourceSpec
section to TaskResourceAttributes
.
There's been lots of confusion around Admin's existing behavior of setting the a task's limits to the same as the requests. Adding a default limit section to admin explicitly will fix this. Limits from now on will just be used for checking that the default requests and default limits conform to the system level limit.
Type
☐ Bug Fix
☑︎ Feature
☐ Plugin
Are all requirements met?
☑︎ Code completed
☑︎ Smoke tested
☐ Unit tests added
☐ Code documentation added
☐ Any pending items have an associated Issue
Complete description
NA
Tracking Issue
flyteorg/flyte#3574
flyteorg/flyte#3467
flyteorg/flyteidl
✅ All checks have passed
13/13 successful checksGitHub
04/18/2023, 7:13 PMGitHub
04/18/2023, 7:23 PMGitHub
04/18/2023, 8:09 PM<https://github.com/flyteorg/flytekit/tree/master|master>
by pingsutw
<https://github.com/flyteorg/flytekit/commit/0a34f4f968e8cbaf62aae9d9227aadcb99b30f32|0a34f4f9>
- Feature: add activate-launchplan command to pyflyte (#1588)
flyteorg/flytekitGitHub
04/18/2023, 8:42 PM$ k edit cm flyte-admin-config
task_resource_defaults.yaml: |
task_resources:
defaults:
cpu: 100m
memory: 500Mi
storage: 500Mi
limits:
cpu: 2
gpu: 1
memory: 1Gi <- change this value
storage: 20Mi
Add it in the environment guide setup or troubleshooting guide. The above config works for sandbox.
For demo cluster, you can't change config at runtime. Hence, change the config and build a custom image.
$ git clone git@github.com:flyteorg/flyte.git
$ cd flyte
$ vim flyte.yaml (update config)
$ docker build -t user_name/sandbox-lite-test -f docker/sandbox-lite/Dockerfile . # Build image
$ docker push user_name/sandbox-lite-test
$ flytectl demo start --image user_name/sandbox-lite-test
OR
docker exec
into the cluster and modify the flyte.yaml file.
docker run -v my_flyte.yaml:flyte.yaml …
docker restart flyte-sandbox
flyteorg/flyteGitHub
04/18/2023, 8:49 PMAttributeError: 'ImperativeWorkflow' object has no attribute
'instantiated_in'
Type
☑︎ Bug Fix
☐ Feature
☐ Plugin
Are all requirements met?
☑︎ Code completed
☑︎ Smoke tested
☐ Unit tests added
☐ Code documentation added
☐ Any pending items have an associated Issue
Complete description
^^^
Tracking Issue
NA
Follow-up issue
NA
flyteorg/flytekit
✅ All checks have passed
30/30 successful checksGitHub
04/18/2023, 9:18 PM<https://github.com/flyteorg/flyteconsole/tree/master|master>
by jsonporter
<https://github.com/flyteorg/flyteconsole/commit/bbe8d51251722e9f6a3cdf77b690648603cdb0a1|bbe8d512>
- chore: fix details panel card padding (#745)
flyteorg/flyteconsoleGitHub
04/18/2023, 9:41 PM<https://github.com/flyteorg/flytesnacks/tree/master|master>
by pingsutw
<https://github.com/flyteorg/flytesnacks/commit/094211ae56c36d4191e6309e643f9430721886c3|094211ae>
- fix whylogs docs (#985)
flyteorg/flytesnacksGitHub
04/18/2023, 9:41 PM<https://github.com/flyteorg/flytekit/tree/master|master>
by eapolinario
<https://github.com/flyteorg/flytekit/commit/c363881c4aeb4fe9a4479e5ff2eef7c03c13e87e|c363881c>
- nit (#1596)
flyteorg/flytekitGitHub
04/18/2023, 10:11 PM<https://github.com/flyteorg/flyteidl/tree/master|master>
by eapolinario
<https://github.com/flyteorg/flyteidl/commit/c7ae927f73df9ecdbbf01b6021836b9b2079e527|c7ae927f>
- Migrate to buf remote plugins v1 (#393)
flyteorg/flyteidl