GitHub
03/27/2023, 11:05 PMGitHub
03/27/2023, 11:22 PMGitHub
03/28/2023, 1:01 AMPluginStateReader
function through the PluginContext
so that k8s plugin writers can retrieve plugin state the same way they do in other plugins, just that persistend (ie. PluginStateWriter
) is performed underneath.
Type
☑︎ Bug Fix
☐ Feature
☐ Plugin
Are all requirements met?
☑︎ Code completed
☑︎ Smoke tested
☐ Unit tests added
☑︎ Code documentation added
☐ Any pending items have an associated Issue
Complete description
^^^
Tracking Issue
fixes flyteorg/flyte#3440
Follow-up issue
NA
flyteorg/flytepropeller
GitHub Actions: Goreleaser
GitHub Actions: Build & Push Flytepropeller Image
GitHub Actions: Bump Version
✅ 11 other checks have passed
11/14 successful checksGitHub
03/28/2023, 1:29 AMflytesnacks/development/human_in_the_loop.wf_dy
)
• relaunch a previous execution
• In the launch form, delete the text value (note: the bug only happens when a user hits backspace/delete; simply highlighting and over-typing a new value seems to work)
Expected behavior
Users should be able to delete a previous value and the validation message should appear... but the browser should not freeze.
Additional context to reproduce
No response
Screenshots
No response
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
03/28/2023, 2:04 AMimage▾
GitHub
03/28/2023, 2:14 AM<https://github.com/flyteorg/flyteconsole/tree/master|master>
by jsonporter
<https://github.com/flyteorg/flyteconsole/commit/6ebd69fc6af1521c579c402fd43074fd663568cf|6ebd69fc>
- Add REJECT support for ApprovedCondition for GateNodes (#733)
flyteorg/flyteconsoleGitHub
03/28/2023, 2:14 AMApproveCondition
. ApprovedCondition only accepts true
(boolean) as an input and should be presented to the user as displaying the incoming input and the simply allowing them to click on 'resume' in the Signal Form. Currently, these nodes (correctly) show the incoming inputs but the resume button is greyed out.
Note: the shape of ApprovedCondition gate nodes is a little different in the CompiledWorkflowClosure
-- look for gateNode
and approve
. Here is an example from core.control_flow.human_in_the_loop.mainwf
// Example of ApprovedCondition
{
"gateNode": {
"approve": {
"signalId": "approvalfory"
}
}
}
IDL: Link to ApprovedCondition in IDL
Goal: What should the final outcome look like, ideally?
Acceptance Criteria:
• Renders incoming inputs (this currently works just make sure the fix doesn't break it)
• Allows user to click "resume" (this is currently greyed out)
• Sends true
as value
Propose: Link/Inline OR Additional context
This was ported over from this other board: unionai/cloud#1518
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
03/28/2023, 5:45 AM<https://github.com/flyteorg/flytekit/tree/master|master>
by eapolinario
<https://github.com/flyteorg/flytekit/commit/28ce9396af2d28a06c45d889372645241afa021f|28ce9396>
- Device auth flow / Headless auth (#1552)
flyteorg/flytekitGitHub
03/28/2023, 9:31 AMGitHub
03/28/2023, 3:41 PMGitHub
03/28/2023, 3:44 PMTransitionTypeBarrier
in support of removing support for BarrierTicks
in FlytePropeller.
Type
☐ Bug Fix
☑︎ Feature
☐ Plugin
Are all requirements met?
☑︎ Code completed
☑︎ Smoke tested
☐ Unit tests added
☑︎ Code documentation added
☐ Any pending items have an associated Issue
Complete description
^^^
Tracking Issue
flyteorg/flyte#3544
Follow-up issue
NA
flyteorg/flyteplugins
Codecov: 62.65% (-0.10%) compared to 60d345d
Codecov: 25.00% of diff hit (target 62.75%)
✅ 4 other checks have passed
4/6 successful checksGitHub
03/28/2023, 3:48 PMGitHub
03/28/2023, 4:25 PM<https://github.com/flyteorg/flytekit/tree/master|master>
by pingsutw
<https://github.com/flyteorg/flytekit/commit/db7d1eb480cea24504d94419981859bfc9ef6c62|db7d1eb4>
- support python 3.11 (#1557)
flyteorg/flytekitGitHub
03/28/2023, 4:25 PMtensorflow
and others don't support 3.11
2. certain parts of the the flytekit codebase (such as the parts that use dataclasses) need to be updated to support 3.11
Python 3.7 will be EOL'd on June 2023, which will ease the transition to 3.11 because we can unpin certain restrictions.
Goal: What should the final outcome look like, ideally?
A user should be able to install and use flytekit on python 3.11
Describe alternatives you've considered
NA
Propose: Link/Inline OR Additional context
No response
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
03/28/2023, 4:33 PMconfiguration.admin.seedProjects
to a list of project names and
(default value = ["flytesnacks"])
Describe alternatives you've considered
1. Creating a flyte-operator
which knows how to read a CRD of desired flyte projects
2. Hooking flytectl into our pulumi powered k8s management
The first option is.. just a lot of work!
The second option is far less work, viable and a completely valid path forward. After discussing with jeev and Yee it seemed both thought the proposed solution is acceptable.
Propose: Link/Inline OR Additional context
Discussed here: https://flyte-org.slack.com/archives/C01P3B761A6/p1679937303586009
I'll go ahead and create a PR for it in the coming days.
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
03/28/2023, 5:24 PMThe request is missing a required parameter, includes an invalid parameter value, includes a parameter more than once, or is otherwise malformed. The client secret in the HTTP authorization header could not be decoded from 'application/x-www-form-urlencoded'.
Type
☑︎ Bug Fix
☐ Feature
☐ Plugin
Are all requirements met?
☑︎ Code completed
☑︎ Smoke tested
☑︎ Unit tests added
☐ Code documentation added
☐ Any pending items have an associated Issue
Complete description
url encode
flyteorg/flytekit
Codecov: 50.00% of diff hit (target 69.66%)
✅ 29 other checks have passed
29/30 successful checksGitHub
03/28/2023, 5:28 PMdisableWebhook
configuration option and start single binary.
Screenshots
No response
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
03/28/2023, 5:29 PMRun
function. This is useful to ensure the controller-runtime manager starts in single binary even if the webhook is disabled.
Type
☐ Bug Fix
☑︎ Feature
☐ Plugin
Are all requirements met?
☑︎ Code completed
☑︎ Smoke tested
☐ Unit tests added
☑︎ Code documentation added
☐ Any pending items have an associated Issue
Complete description
^^^
Tracking Issue
flyteorg/flyte#3546
Follow-up issue
NA
flyteorg/flytepropeller
GitHub Actions: Goreleaser
GitHub Actions: Build & Push Flytepropeller Image
GitHub Actions: Bump Version
✅ 11 other checks have passed
11/14 successful checksGitHub
03/28/2023, 6:41 PM<https://github.com/flyteorg/flytekit/tree/master|master>
by eapolinario
<https://github.com/flyteorg/flytekit/commit/dd7fbe90ed5e9566e9b19d0e8b8bb8011770d835|dd7fbe90>
- url encode secret in client credentials flow (#1566)
flyteorg/flytekitGitHub
03/28/2023, 6:54 PM<https://github.com/flyteorg/flytekit-python-template/tree/main|main>
by zeryx
<https://github.com/flyteorg/flytekit-python-template/commit/30606aacce4a30d0dc2506923be3bb17aecd8f45|30606aac>
- MNIST Pytorch Training Example (#22)
flyteorg/flytekit-python-templateGitHub
03/28/2023, 7:50 PMGitHub
03/28/2023, 9:13 PMPrimaryContainerKey
annotation by default so that (1) Pods
may be marked as completed immediately after the container completes, rather than waiting for the Pod
to be marked as completed as well and (2) users can inject sidecars outside of Flyte that will not halt the task from being marked completed.
Type
☐ Bug Fix
☑︎ Feature
☐ Plugin
Are all requirements met?
☑︎ Code completed
☑︎ Smoke tested
☐ Unit tests added
☑︎ Code documentation added
☐ Any pending items have an associated Issue
Complete description
^^^
Tracking Issue
NA
Follow-up issue
NA
flyteorg/flyteplugins
✅ All checks have passed
6/6 successful checksGitHub
03/28/2023, 9:20 PMGitHub
03/28/2023, 11:51 PM<https://github.com/flyteorg/flyteidl/tree/master|master>
by katrogan
<https://github.com/flyteorg/flyteidl/commit/bb5d4cd8c6ceebbd386137348fbbb2765c21370e|bb5d4cd8>
- Remove misleading token refresh logic from client credentials token source provider (#383)
flyteorg/flyteidlGitHub
03/28/2023, 11:52 PMGitHub
03/28/2023, 11:55 PMclass CustomJsonFormatter(jsonlogger.JsonFormatter):
def add_fields(
self, log_record: dict, record: logging.LogRecord, message_dict: dict
) -> None:
super().add_fields(log_record, record, message_dict)
log_record["severity"] = record.levelname
This works after user code is loaded, but all logs that are output before user code is run are still formatted incorrectly (see screenshot).
image▾
GitHub
03/29/2023, 12:16 AM<https://github.com/flyteorg/flytekit/tree/master|master>
by pingsutw
<https://github.com/flyteorg/flytekit/commit/12be8d871bb68d6d1dd6adc57288ab9b544e5536|12be8d87>
- Python run multiple files (#1559)
flyteorg/flytekitGitHub
03/29/2023, 12:29 AM@task(
cache=True,
cache_version="1.0.0",
)
def fds_importer_parameter_serialization(a: str) -> str:
return "hello" + a
@workflow
def fds_importer(a: str):
fds_importer_parameter_serialization(a)
File2
@reference_launch_plan
def fds_importer(a: str):
...
@workflow
def my_workflow(a: str):
fds_importer(a)
Screenshots
Screenshot 2023-03-28 at 5 28 08 PM▾
Screenshot 2023-03-28 at 5 28 15 PM▾
GitHub
03/29/2023, 7:35 AMGitHub
03/29/2023, 7:41 AM<https://github.com/flyteorg/flytekit-java/tree/master|master>
by github-actions[bot]
<https://github.com/flyteorg/flytekit-java/commit/d8eaf53f4981efe58c1b7ba4a4c0860554c5711c|d8eaf53f>
- [maven-release-plugin] prepare release 0.4.14
flyteorg/flytekit-java