GitHub
03/16/2023, 12:31 AM<https://github.com/flyteorg/flyte-attendant/tree/main|main>
by cosmicBboy
<https://github.com/flyteorg/flyte-attendant/commit/c4b199293d270a55cb5cbd44787ff4c345056cc7|c4b19929>
- add loading text
flyteorg/flyte-attendantGitHub
03/16/2023, 2:06 PMGitHub
03/16/2023, 3:34 PM<https://github.com/flyteorg/flyte-attendant/tree/main|main>
by cosmicBboy
<https://github.com/flyteorg/flyte-attendant/commit/fbda3ee1d8b599abd9442fd791b5c7d1c17514f6|fbda3ee1>
- ignore katacoda tutorials
<https://github.com/flyteorg/flyte-attendant/commit/af976bda2e7330202c2da3899e19b1bd9b8ac9a8|af976bda>
- update cache version
<https://github.com/flyteorg/flyte-attendant/commit/94de578bd8c0b861a972b90112f14962fe75c36b|94de578b>
- update app
<https://github.com/flyteorg/flyte-attendant/commit/b1c5a3df691d7b3acb27165b6dc5c19cab6b234f|b1c5a3df>
- app typos
<https://github.com/flyteorg/flyte-attendant/commit/ba43b47aeaa04860763d0f47a671c66e91fe4492|ba43b47a>
- update app
<https://github.com/flyteorg/flyte-attendant/commit/5973e823a0cfe7b0d1d95de238b99ea06260e6e1|5973e823>
- update app copy
flyteorg/flyte-attendantGitHub
03/16/2023, 4:16 PM<https://github.com/flyteorg/flytesnacks/tree/master|master>
by cosmicBboy
<https://github.com/flyteorg/flytesnacks/commit/878271d118e96862ceaf34c4e0293be9c1e6d5b9|878271d1>
- Add gate node example to the control flow section of flytesnacks (#968)
flyteorg/flytesnacksGitHub
03/16/2023, 5:35 PMGitHub
03/16/2023, 5:40 PMflytepropeller-1 flytepropeller E0315 17:26:22.419072 1 workers.go:102] error syncing 'flyte-attendant-development/fbf61da4211b749988f0': failed at Node[n1]. RuntimeExecutionError: failed during plugin execution, caused by: failed to execute handle for plugin [container]: [Invalid] failed to create resource, caused by: Pod "fbf61da4211b749988f0-n1-0" is invalid: [spec.containers[0].env[26].name: Invalid value: "_FSEC_ARN:AWS:SECRETSMANAGER:US-EAST-2:356633062068:SECRET:_OPENAI_API_KEY-QA0K0U": a valid environment variable name must consist of alphabetic characters, digits, '_', '-', or '.', and must not start with a digit (e.g. 'my.env-name', or 'MY_ENV.NAME', or 'MyEnvName1', regex used for validation is '[-._a-zA-Z][-._a-zA-Z0-9]*'), spec.containers[0].env[26].valueFrom.secretKeyRef.name: Invalid value: "arn:aws:secretsmanager:us-east-2:356633062068:secret:": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. '<http://example.com|example.com>', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')]
There is no progress that propeller can make with this workflow .
This ticket tracks.
• Adding validation in flytekit to disallow non-conforming secret names to be registered
• Propeller should auto abort/cancel such tasks and send the validation error over so that admin can showcase the issue and the UI can render it
• Existing workflows which bypassed this check should some how be flagged
Expected behavior
Disallow incorrect workflows and propeller should abort if any such incorrect workflows fall through the cracks and flyteadmin and UI should be able to show the right issue in the workflow
Additional context to reproduce
No response
Screenshots
No response
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
03/16/2023, 6:06 PMGitHub
03/16/2023, 6:07 PMGitHub
03/16/2023, 6:09 PMGitHub
03/16/2023, 6:11 PMflyteconsole
UI for workflows typically shows a preview of the workflow's inputs. However, when changes are made the workflow's signature and the registration is updated, the UI continues to show the outdated workflow signature rather than the latest, most recent version's signature.
This is a pretty minor bug since clicking on Launch Workflow
does bring up the correct workflow inputs.
image▾
flyteconsole
UI should show the latest version of a workflow's signature.
Additional context to reproduce
1. Create a dummy project and workflow
from flytekit import task, workflow
@task
def addition_task(a: int, b: int) -> int:
return a + b
@workflow
def dummy_wf(a: int, b: int) -> int:
return addition_task(a=a, b=b)
2. package and register the project + workflow. The UI should look as follows:
image▾
image▾
from flytekit import task, workflow
@task
def addition_task(a: int, b: int) -> int:
return a + b
@workflow
def dummy_wf(a: int, b: int, c: int, d: str) -> int:
return addition_task(a=a, b=b)
4. Package and register the updated workflow. Note the UI still shows the older version's signature despite there being a newer / more recent version
image▾
image▾
image▾
GitHub
03/16/2023, 6:12 PMGitHub
03/16/2023, 6:12 PMimage▾
GitHub
03/16/2023, 6:13 PMScreen Shot 2022-05-16 at 12 09 47 PM▾
GitHub
03/16/2023, 6:14 PMTODO FC#393: what's need to be done
whenever cleanup is needed.
Current list of cleanups:
Simplify WorkflowTabs
usage in NodeExecutionDetailsPanelContent
Remove inputs/outputs fields from ExecutionData
interface, ensure that they are not used anymore
Unify showOnHoverClass
usage - move it to commonStyles, for both parent, and child style
Move all Core. and Admin. enums to one file: src/models/enums.ts
(could be found by It's an ENUM exports
string)
move createWorkflowName
into src/components/Project/test/ProjectWorkflows.test.tsx
Storybooks for all olf flyteconsole components should start with Legacy/
path in stories location(eg. const stories = storiesOf('Navigation/NavBar', module);
) to ensure that we now that the y should be reimplemented/updated up to new standart
flyteorg/flyteconsoleGitHub
03/16/2023, 6:15 PMLast 10 executions
on each of returned workflow we perform executions call
Screen Shot 2022-04-13 at 3 32 42 PM▾
useWorkflowNameList
from src/components/hooks/useNamedEntity.ts
, which already have limit set to
limits.DEFAULT === 25
Load more items when user have already scrolled through have of the list.
flyteorg/flyteconsoleGitHub
03/16/2023, 6:15 PMScreen Shot 2022-04-13 at 2 50 23 PM▾
GitHub
03/16/2023, 6:17 PMlC0y/z2YQl3FJ5qO7c441w==
• Filter executions by lC0y/z2YQl3FJ5qO7c441w==
version, open execution and navigate to Graph tab
Screen Shot 2022-04-13 at 1 27 01 PM▾
GitHub
03/16/2023, 6:20 PMmy_subwf
• Graph and timeline show it up as a regular python task
Most probably the issue is connected to DagV2 parsing.
Goal
Show al child tasks in Timeline and Graph view
flyteorg/flyteconsoleGitHub
03/16/2023, 6:21 PMimage▾
image▾
image▾
image▾
GitHub
03/16/2023, 6:22 PMScreen Shot 2022-03-17 at 10 02 14 AM▾
allegedDurationSec
- longest currently available duration happened earlier in the Dag tree.
Proper solutions
Ideally we should:
• Mark status as ABORTED if parent item has FAILED state (which is not that easy to do with current DAG system)
• Fix backend to ensure that status is updating properly
flyteorg/flyteconsoleGitHub
03/16/2023, 6:25 PMGitHub
03/16/2023, 6:25 PMTimeline View▾
GitHub
03/16/2023, 6:26 PMflytectl get launchplan
command provides e.g.
--------- ------------------------------------------------ ------ ------- ------------------------------------------- -------------- ---------
| VERSION | NAME | TYPE | STATE | SCHEDULE | INPUTS | OUTPUTS |
--------- ------------------------------------------------ ------ ------- ------------------------------------------- -------------- ---------
| aa8d820 | awesome_workflow.workflows.launchplan.schedule | | | map[cronSchedule:map[schedule:0 10 * * 1] | kickoff_time | o0 |
| | | | | kickoffTimeInputArg:kickoff_time] | | |
--------- ------------------------------------------------ ------ ------- ------------------------------------------- -------------- ---------
| fe791e5 | awesome_workflow.workflows.launchplan.schedule | | | map[cronSchedule:map[schedule:0 10 * * 1] | a | o0 |
| | | | | kickoffTimeInputArg:kickoff_time] | b | |
| | | | | | kickoff_time | |
--------- ------------------------------------------------ ------ ------- ------------------------------------------- -------------- ---------
and clicking one of the launch plan will lead to opening launchplan details page. (related to flyteorg/flyteconsole#407)
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
03/16/2023, 6:28 PMScreen Shot 2021-10-15 at 8 53 51 AM▾
GitHub
03/16/2023, 6:29 PMScreen Shot 2021-10-15 at 8 58 34 AM▾
GitHub
03/16/2023, 6:30 PMGitHub
03/16/2023, 7:33 PM<https://github.com/flyteorg/flyte-attendant/tree/main|main>
by cosmicBboy
<https://github.com/flyteorg/flyte-attendant/commit/3d01b39b3bfabfdd9ea3f47e500f1866c4ff5d1e|3d01b39b>
- debug auth
flyteorg/flyte-attendantGitHub
03/16/2023, 7:37 PM<https://github.com/flyteorg/flyte-attendant/tree/main|main>
by cosmicBboy
<https://github.com/flyteorg/flyte-attendant/commit/e77600ec4ec88d4f1c48899673e525313968412f|e77600ec>
- revert authType to clientSecret
flyteorg/flyte-attendantGitHub
03/16/2023, 8:35 PMn
, y
, no
, yes
, etc. flytectl
fails to unmarshal the spec correctly. As an example:
inputs:
n: 42
flytectl
wil fail with
Error: no matching type for [false]
{"json":{},"level":"error","msg":"no matching type for [false]","ts":"2023-03-14T10:48:56-04:00"}
After a quick investigation, this is because of using sigs.k8s.io/yaml in flytectl: https://github.com/flyteorg/flytectl/blob/cea39d9bdf2476f9a5313d1bf19bf08b3923237a/cmd/create/execution_util.go#L13. This yaml library depends on go-yaml
v2, which does not support YAML 1.2 specification, see go-yaml/yaml#214. If an input argument is named as n
, when creating an execution via a execution spec file, that argument must be quoted as "n"
, otherwise flytectl
would fail because when unmarshalling n
is parsed as false
as the input parameter name.
Expected behavior
flytectl
should correctly unmarshal the execution spec that is compliant with YAML 1.2 specification.
Additional context to reproduce
No response
Screenshots
No response
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
03/16/2023, 9:03 PM