GitHub
03/06/2023, 12:28 PM<https://github.com/flyteorg/flyteplugins/tree/master|master>
by hamersaw
<https://github.com/flyteorg/flyteplugins/commit/114645a32fc5689a3fa24676900f46cb3223d375|114645a3>
- If primaryContainerName=="primary", container content will be duplicated (#326)
flyteorg/flytepluginsGitHub
03/06/2023, 12:29 PMGitHub
03/06/2023, 12:43 PMGitHub
03/06/2023, 12:45 PM<https://github.com/flyteorg/flyteplugins/tree/master|master>
by hamersaw
<https://github.com/flyteorg/flyteplugins/commit/be833e2882885b4cee956559b7cc9e16c38c7d5a|be833e28>
- Remove chief!=0 or ps!=0 assertion in tensorflow (#327)
flyteorg/flytepluginsGitHub
03/06/2023, 12:45 PMGitHub
03/06/2023, 2:44 PMGitHub
03/06/2023, 3:19 PM<https://github.com/flyteorg/flytepropeller/tree/master|master>
by hamersaw
<https://github.com/flyteorg/flytepropeller/commit/3c3ec339ef4479b92e3c2bcdb6e702da6ac64610|3c3ec339>
- bumping flyteplugins (#537)
flyteorg/flytepropellerGitHub
03/06/2023, 3:36 PMdynamic
workflows requires fully-specifying the arguments to a task
. This behavior is clunky in the context of map tasks, where users need to write a bunch of code to prepare the inputs to a map task (see here.
The purpose of this issue is to support partial tasks, which allow users to partially bind inputs to a task so that it can then be invoked with the remaining arguments, similar to https://docs.python.org/3/library/functools.html#functools.partial.
Goal: What should the final outcome look like, ideally?
Requirements
Partial tasks should:
1. support partial task inputs that are python values
2. support partial task inputs that are promises
3. support partial task definitions in the top-level scope of a module
4. support use of partial tasks in map tasks
Once partial tasks are implemented, it should look something like:
Support partial task inputs that are python values
from flytekit import task, workflow, partial
@task
def t1(x: int, y: float) -> float:
return x + y
@workflow
def wf(y: float):
partial_t1 = partial(t1, x=5)
return partial_t1(y=y)
Support partial task inputs that are promises
from flytekit import task, workflow, partial
@task
def t1(x: int, y: float) -> float:
return x + y
@task
def t2() -> int:
return 5
@workflow
def wf(y: float):
partial_t1 = partial(t1, x=t2())
return partial_t1(y=y)
Support partials in the top-level module scope
If a user wants to specify partial tasks using python literal values in the top-level scope:
from flytekit import task, workflow, partial
@task
def t1(x: int, y: float) -> float:
return x + y
partial_t1 = partial(t1, x=5)
@workflow
def wf(y: float):
return partial_t1(y=y)
Support partials in map tasks
from flytekit import task, workflow, partial, map_task
@task
def t1(x: int, y: float) -> float:
return x + y
@workflow
def wf(y: List[float]):
partial_t1 = partial(t1, x=5)
return map_task(partial_t1)(y=y)
Describe alternatives you've considered
Besides syntactic alternatives, not supporting partial tasks would require writing additional code to make some of Flyte's constructs work (e.g. map tasks with multiple inputs).
Propose: Link/Inline OR Additional context
No response
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
03/06/2023, 4:01 PMGitHub
03/06/2023, 4:08 PMGitHub
03/06/2023, 4:27 PMGitHub
03/06/2023, 4:36 PMGitHub
03/06/2023, 4:42 PMGitHub
03/06/2023, 4:44 PMGitHub
03/06/2023, 6:13 PM{"json":{},"level":"fatal","msg":"panic-ed for request: [workflow_execution_id:\u003cproject:\"flytesnacks\"
domain:\"development\" name:\"fe8b97db1a638438181a\" \u003e limit:10000 sort_by:\u003ckey:\"created_at\"
direction:ASCENDING \u003e ] with err: runtime error: slice bounds out of range [:100] with length 17 with Stack:
goroutine 2580 [running]:\nruntime/debug.Stack()\n\t/usr/local/go/src/runtime/debug/stack.go:24
+0x65\<http://ngithub.com/flyteorg/flyteadmin/pkg/rpc/adminservice.(*AdminService).interceptPanic|ngithub.com/flyteorg/flyteadmin/pkg/rpc/adminservice.(*AdminService).interceptPanic>(0xc001db8000,
{0x2c094d0, 0xc004129f20}, {0x2bf7f00?,
0xc003e6d030})\n\t/go/src/github.com/flyteorg/flyteadmin/pkg/rpc/adminservice/base.go:59 +0x85\npanic({0x2505d20,
0xc00114e900})\n\t/usr/local/go/src/runtime/panic.go:838
+0x207\<http://ngithub.com/flyteorg/flyteadmin/pkg/repositories/transformers.FromNodeExecutionModel(|ngithub.com/flyteorg/flyteadmin/pkg/repositories/transformers.FromNodeExecutionModel(>{{0x6b3, {0x5a03368,
0xedb8b4159, 0x4004360}, {0x1390c618, 0xedb8b463b, 0x4004360}, 0x0}, {{{0xc00407ac70, 0xb}, ...}, ...}, ...},
...)\n\t/go/src/github.com/flyteorg/flyteadmin/pkg/repositories/transformers/node_execution.go:289
+0x3ed\<http://ngithub.com/flyteorg/flyteadmin/pkg/manager/impl.(*NodeExecutionManager).transformNodeExecutionModel(_|ngithub.com/flyteorg/flyteadmin/pkg/manager/impl.(*NodeExecutionManager).transformNodeExecutionModel(_>,
{_, _}, {{0x6b3, {0x5a03368, 0xedb8b4159, 0x4004360}, {0x1390c618, 0xedb8b463b, 0x4004360}, ...}, ...},
...)\n\t/go/src/github.com/flyteorg/flyteadmin/pkg/manager/impl/node_execution_manager.go:326
+0x205\<http://ngithub.com/flyteorg/flyteadmin/pkg/manager/impl|ngithub.com/flyteorg/flyteadmin/pkg/manager/impl>.
(*NodeExecutionManager).transformNodeExecutionModelList(0x2710?, {0x2c094d0, 0xc004148210}, {0xc0040a2000,
0x2, 0xc00412d790?})\n\t/go/src/github.com/flyteorg/flyteadmin/pkg/manager/impl/node_execution_manager.go:337
+0x216\<http://ngithub.com/flyteorg/flyteadmin/pkg/manager/impl.(*NodeExecutionManager).listNodeExecutions(0xc0004188c0|ngithub.com/flyteorg/flyteadmin/pkg/manager/impl.(*NodeExecutionManager).listNodeExecutions(0xc0004188c0>,
{0x2c094d0, 0xc004148210}, {0xc004148240?, 0x3, 0x3}, {0x0?, 0x0?}, 0x2710, {0x0, ...},
...)\n\t/go/src/github.com/flyteorg/flyteadmin/pkg/manager/impl/node_execution_manager.go:411
+0x34d\<http://ngithub.com/flyteorg/flyteadmin/pkg/manager/impl|ngithub.com/flyteorg/flyteadmin/pkg/manager/impl>.
(*NodeExecutionManager).ListNodeExecutions(0xc0004188c0, {0x2c094d0, 0xc004129f20}, {0xc004146000, 0x2710,
{0x0, 0x0}, {0x0, 0x0}, 0xc003e6f300,
...})\n\t/go/src/github.com/flyteorg/flyteadmin/pkg/manager/impl/node_execution_manager.go:455
+0x37b\<http://ngithub.com/flyteorg/flyteadmin/pkg/rpc/adminservice|ngithub.com/flyteorg/flyteadmin/pkg/rpc/adminservice>.
(*AdminService).ListNodeExecutions.func1()\n\t/go/src/github.com/flyteorg/flyteadmin/pkg/rpc/adminservice/node_executi
on.go:60 +0xb6\<http://ngithub.com/flyteorg/flytestdlib/promutils.StopWatch.Time({{0x7f4b4a00d3e8|ngithub.com/flyteorg/flytestdlib/promutils.StopWatch.Time({{0x7f4b4a00d3e8>?, 0xc001928c00?},
0x81b220?}, 0xc000731920)\n\t/go/pkg/mod/github.com/flyteorg/flytestdlib@v1.0.14/promutils/scope.go:59
+0xc2\<http://ngithub.com/flyteorg/flyteadmin/pkg/rpc/adminservice/util.(*RequestMetrics).Time(...)\n\t/go/src/github.com/flyteorg/flyteadmin/pkg/rpc/adminservice/util/metrics.go:33\ngithub.co|ngithub.com/flyteorg/flyteadmin/pkg/rpc/adminservice/util.(*RequestMetrics).Time(...)\n\t/go/src/github.com/flyteorg/flyteadmin/pkg/rpc/adminservice/util/metrics.go:33\ngithub.co>
m/flyteorg/flyteadmin/pkg/rpc/adminservice.(*AdminService).ListNodeExecutions(0xc001db8000, {0x2c094d0?,
0xc004129f20?}, 0xc004148090?)\n\t/go/src/github.com/flyteorg/flyteadmin/pkg/rpc/adminservice/node_execution.go:59 +0x169\<http://ngithub.com/flyteorg/flyteidl/gen/pb-|ngithub.com/flyteorg/flyteidl/gen/pb->
go/flyteidl/service._AdminService_ListNodeExecutions_Handler.func1({0x2c094d0, 0xc004129f20}, {0x25a23a0?,
0xc003e6d030})\n\t/go/pkg/mod/github.com/flyteorg/flyteidl@v1.3.7/gen/pb-go/flyteidl/service/admin.pb.go:1492
+0x7b\<http://ngithub.com/grpc-ecosystem/go-grpc-prometheus.(*ServerMetrics).UnaryServerInterceptor.func1({0x2c094d0|ngithub.com/grpc-ecosystem/go-grpc-prometheus.(*ServerMetrics).UnaryServerInterceptor.func1({0x2c094d0>,
0xc004129f20}, {0x25a23a0, 0xc003e6d030}, 0x7f4b4a19ac28?, 0xc0041440c0)\n\t/go/pkg/mod/github.com/grpc-
ecosystem/go-grpc-prometheus@v1.2.0/server_metrics.go:107 +0x87\<http://ngithub.com/grpc-ecosystem/go-grpc-|ngithub.com/grpc-ecosystem/go-grpc->
middleware.ChainUnaryServer.func1.1.1({0x2c094d0?, 0xc004129f20?}, {0x25a23a0?,
0xc003e6d030?})\n\t/go/pkg/mod/github.com/grpc-ecosystem/go-grpc-middleware@v1.3.0/chain.go:25
+0x3a\<http://ngithub.com/grpc-ecosystem/go-grpc-middleware.ChainUnaryServer.func1({0x2c094d0|ngithub.com/grpc-ecosystem/go-grpc-middleware.ChainUnaryServer.func1({0x2c094d0>, 0xc004129f20},
{0x25a23a0, 0xc003e6d030}, 0xc00252eaf0?, 0x22d83e0?)\n\t/go/pkg/mod/github.com/grpc-ecosystem/go-grpc-
middleware@v1.3.0/chain.go:34 +0xbf\<http://ngithub.com/flyteorg/flyteidl/gen/pb-|ngithub.com/flyteorg/flyteidl/gen/pb->
go/flyteidl/service._AdminService_ListNodeExecutions_Handler({0x266c740?, 0xc001db8000}, {0x2c094d0,
0xc004129f20}, 0xc00193ad80, 0xc0005d37a0)\n\t/go/pkg/mod/github.com/flyteorg/flyteidl@v1.3.7/gen/pb-
go/flyteidl/service/admin.pb.go:1494 +0x138\<http://ngoogle.golang.org/grpc.(*Server).processUnaryRPC(0xc000640380|ngoogle.golang.org/grpc.(*Server).processUnaryRPC(0xc000640380>,
{0x2c11e20, 0xc0002411e0}, 0xc0000a0000, 0xc001d012c0, 0x3fe35e0,
0x0)\n\t/go/pkg/mod/google.golang.org/grpc@v1.46.0/server.go:1283 +0xcfd\<http://ngoogle.golang.org/grpc|ngoogle.golang.org/grpc>.
(*Server).handleStream(0xc000640380, {0x2c11e20, 0xc0002411e0}, 0xc0000a0000,
0x0)\n\t/go/pkg/mod/google.golang.org/grpc@v1.46.0/server.go:1620 +0xa1b\<http://ngoogle.golang.org/grpc|ngoogle.golang.org/grpc>.
(*Server).serveStreams.func1.2()\n\t/go/pkg/mod/google.golang.org/grpc@v1.46.0/server.go:922 +0x98\ncreated by
<http://google.golang.org/grpc.(*Server).serveStreams.func1\n\t/go/pkg/mod/google.golang.org/grpc@v1.46.0/server.go:920|google.golang.org/grpc.(*Server).serveStreams.func1\n\t/go/pkg/mod/google.golang.org/grpc@v1.46.0/server.go:920>
+0x28a\n","ts":"2023-03-06T17:24:12Z"}
Type
☑︎ Bug Fix
☐ Feature
☐ Plugin
Are all requirements met?
☑︎ Code completed
☑︎ Smoke tested
☐ Unit tests added
☐ Code documentation added
☐ Any pending items have an associated Issue
Complete description
image▾
GitHub
03/06/2023, 6:16 PM<https://github.com/flyteorg/flyte/tree/master|master>
by wild-endeavor
<https://github.com/flyteorg/flyte/commit/b7afefa867dfb9460450417ef7ad5b8038ddfe0b|b7afefa8>
- Add ip alb ingress target type for EKS values (#3343)
flyteorg/flyteGitHub
03/06/2023, 6:23 PM<https://github.com/flyteorg/flyteconsole/tree/master|master>
by ursucarina
<https://github.com/flyteorg/flyteconsole/commit/c075f4fc22de6f88c9bbda749da07916ffc92f26|c075f4fc>
- fix: revert node version (#704)
flyteorg/flyteconsoleGitHub
03/06/2023, 7:29 PM<https://github.com/flyteorg/flyteadmin/tree/master|master>
by pingsutw
<https://github.com/flyteorg/flyteadmin/commit/326ca45e63f2c2d09be6f87fd72851b22c21e13a|326ca45e>
- Truncate execution error message only when size exceeds limit (#533)
flyteorg/flyteadminGitHub
03/06/2023, 7:35 PMimage▾
GitHub
03/06/2023, 7:46 PMGitHub
03/06/2023, 8:03 PMflytectl update workflow
) in docs doesn't exist and should be workflow-meta
instead.
Type
☑︎ Bug Fix
☐ Feature
☐ Plugin
Are all requirements met?
☐ Code completed
☐ Smoke tested
☐ Unit tests added
☐ Code documentation added
☐ Any pending items have an associated Issue
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/
flyteorg/flytectl
GitHub Actions: Check Go Gennerate / Go Generate
GitHub Actions: Unit Tests / Run Unit Test
GitHub Actions: Lint / Run Lint
GitHub Actions: Test Getting started
GitHub Actions: Dry Run Goreleaser
✅ 2 other checks have passed
2/7 successful checksGitHub
03/06/2023, 8:18 PMGitHub
03/06/2023, 8:30 PMgo
shouldn't be needed.
Tracking Issue
Closes flyteorg/flyte#3406
Follow-up issue
NA
flyteorg/flytectl
GitHub Actions: Goreleaser
GitHub Actions: Generate documentation
GitHub Actions: Bump Version
✅ 9 other checks have passed
9/12 successful checksGitHub
03/06/2023, 8:32 PMbrew install flyteorg/homebrew-tap/flytectl
does not install go as the dependency.
Additional context to reproduce
No response
Screenshots
No response
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
03/06/2023, 9:03 PM<https://github.com/flyteorg/flytepropeller/tree/master|master>
by eapolinario
<https://github.com/flyteorg/flytepropeller/commit/328a41c0f266eaa8555fbc119c7c6a5499a8937f|328a41c0>
- Extend pod webhook self-signed certs expiration date to 99 years in the future (#535)
flyteorg/flytepropellerGitHub
03/06/2023, 9:03 PMfailurePolicy
on the mutating webhook configuration is set to Ignore
by default this means that transparently secrets will stop getting injected - resulting in task failures.
Expected behavior
Secret injection should support a longer than 1 year lifetime.
Additional context to reproduce
Just have a really long running pod webhook deployment .. like really long ... and start to notice that secret injection doesn't work anymore.
Screenshots
No response
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
03/06/2023, 9:39 PMGitHub
03/06/2023, 10:16 PM<https://github.com/flyteorg/flyteconsole/tree/master|master>
by ursucarina
<https://github.com/flyteorg/flyteconsole/commit/154e5ed255a3233ac299561d9266d05581133b5b|154e5ed2>
- fix: deployment optimization (#706)
flyteorg/flyteconsoleGitHub
03/06/2023, 10:33 PMGitHub
03/06/2023, 10:39 PM@dependabot rebase
.
* * *
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
• @dependabot rebase
will rebase this PR
• @dependabot recreate
will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge
will merge this PR after your CI passes on it
• @dependabot squash and merge
will squash and merge this PR after your CI passes on it
• @dependabot cancel merge
will cancel a previously requested merge and block automerging
• @dependabot reopen
will reopen this PR if it is closed
• @dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels
will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language
You can disable automated security fix PRs for this repo from the Security Alerts page.
flyteorg/datacatalog
GitHub Actions: Goreleaser
GitHub Actions: Build & Push Datacatalog Image
GitHub Actions: Bump Version
✅ 8 other checks have passed
8/11 successful checks