GitHub
01/30/2023, 7:15 PM<https://github.com/flyteorg/furo/tree/main|main>
by cosmicBboy
<https://github.com/flyteorg/furo/commit/8ba17005b9872a42eace45d3f4016eb2c0a9e5b9|8ba17005>
- fix page.html
flyteorg/furoGitHub
01/30/2023, 7:17 PMGitHub
01/30/2023, 7:18 PM<https://github.com/flyteorg/flyte/tree/master|master>
by cosmicBboy
<https://github.com/flyteorg/flyte/commit/88729df96c53d95d944c00fb2684903ea19dba87|88729df9>
- remove getting started (#3298)
flyteorg/flyteGitHub
01/30/2023, 8:05 PMGitHub
01/31/2023, 1:14 AMGitHub
01/31/2023, 1:20 AMpip freeze
• If jupyter is in the path, workflows/*.ipynb will be transformed to *.py files.
flyteorg/flytekit-python-template
DCO: DCO
✅ 1 other check has passed
1/2 successful checksGitHub
01/31/2023, 1:57 AM@task
def test(x: int) -> int:
return x + 1
@task
def echo_integer(value: int) -> int:
logging.error(f"I've got value {value}")
return test(x=value + 5) + 1
@workflow
def wf(
value: int,
):
return echo_integer(value=value)
Expected behavior
The above code should work when run locally
edit: flytekit should also log a warning saying that the inner task is executed as a function and not an atomic entity
Additional context to reproduce
No response
Screenshots
No response
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
01/31/2023, 2:35 AM<https://github.com/flyteorg/flyte/tree/master|master>
by cosmicBboy
<https://github.com/flyteorg/flyte/commit/b4590fa0da0bdb2f5237bc788c2a1ff3c8f99dd9|b4590fa0>
- Update Administrator docs (#3116)
flyteorg/flyteGitHub
01/31/2023, 4:07 AMv6.0.6.1
Active Support
• No changes.
Active Model
• No changes.
Active Record
• Makemore strictsanitize_as_sql_comment
Though this method was likely never meant to take user input, it was attempting sanitization. That sanitization could be bypassed with carefully crafted input.
This commit makes the sanitization more robust by replacing any occurrances of "/_" or "_/" with "/ " or " /". It also performs a first pass to remove one surrounding comment to avoid compatibility issues for users relying on the existing removal.
This also clarifies in the documentation of annotate that it should not be provided user input.
[CVE-2023-22794]
Action View
• No changes.
Action Pack
• No changes.
Active Job
• No changes.... (truncated) Commits • `28bb76d` Version 6.0.6.1 • `91cf62e` Version 6.0.6 • `c7d64e9` Preparing for 6.0.5.1 release • `c177e45` updating version and changelog • See full diff in compare view Dependabot compatibility score Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.
* * *
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
• @dependabot rebase
will rebase this PR
• @dependabot recreate
will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge
will merge this PR after your CI passes on it
• @dependabot squash and merge
will squash and merge this PR after your CI passes on it
• @dependabot cancel merge
will cancel a previously requested merge and block automerging
• @dependabot reopen
will reopen this PR if it is closed
• @dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels
will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language
You can disable automated security fix PRs for this repo from the Security Alerts page.
flyteorg/flyteorg.github.io
✅ All checks have passed
2/2 successful checksGitHub
01/31/2023, 6:16 AMGitHub
01/31/2023, 4:08 PMGitHub
01/31/2023, 4:32 PMnil
, rather then checking if the variable list exists and is empty as well. This means, depending on the definition, Flyte may inject a container to, for example, upload the outputs of a task when that task does not have any outputs. This PR validates variable existence to ensure copilot sidcars are not unnecessarily created.
Type
☑︎ Bug Fix
☐ Feature
☐ Plugin
Are all requirements met?
☑︎ Code completed
☑︎ Smoke tested
☐ Unit tests added
☑︎ Code documentation added
☐ Any pending items have an associated Issue
Complete description
^^^
Tracking Issue
fixes flyteorg/flyte#3254
Follow-up issue
NA
flyteorg/flyteplugins
Codecov: 62.90% (-0.12%) compared to 109224c
✅ 5 other checks have passed
5/6 successful checksGitHub
01/31/2023, 4:35 PMremote_path
for StructuredDatasets
, but being able to just run local executions against s3 would mean I would write less code. This might not make sense if the workflow artifacts are hard to interpret out of context.
This is a pretty low priority request.
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
01/31/2023, 4:35 PMisort
in the venv created by pre-commit (e.g. #1426 and #1420).
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/
flyteorg/flytekit
✅ All checks have passed
30/30 successful checksGitHub
01/31/2023, 6:42 PM--source
flag in flytectl is no longer necessary.
Flytectl
• Allow users to start with an external flyte config
• Allow users to modify a config and reload
• Print current state of cluster
Docs
Implement the new user journey, moving the more difficult error prone things like auth and ingress to later stages.
Helm
Refactor and introduce new Helm charts that use the single binary.
Misc
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
01/31/2023, 6:50 PM<https://github.com/flyteorg/flytekit/tree/master|master>
by eapolinario
<https://github.com/flyteorg/flytekit/commit/88c6bba6c3b114e9f80fca1768cafd6920935fac|88c6bba6>
- Bump isort to 5.12.0 (#1427)
flyteorg/flytekitGitHub
01/31/2023, 7:17 PMflytectl get task
lists all tasks of a given project and domain. One of the parameters of that command is --version
(or --latest
), which allows you to list tasks for a specific version. That parameter is not being honored currently.
Expected behavior
flytectl get task --project <project> --domain <domain> --version <version>
should return all tasks for version <version>
.
Additional context to reproduce
No response
Screenshots
No response
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
01/31/2023, 8:02 PMGitHub
01/31/2023, 9:17 PM<https://github.com/flyteorg/flytekit/tree/master|master>
by eapolinario
<https://github.com/flyteorg/flytekit/commit/ea39054223a9432692c03314b90c45240f2d8419|ea390542>
- Fixes guess type bug in UnionTransformer (#1426)
flyteorg/flytekitGitHub
02/01/2023, 1:27 AMdict
or typing.Dict
annotation. This will break code that relies on precise types, such as sklearn, which explicitly checks the types of hyperparameter values in Estimator constructor.
Type
☑︎ Bug Fix
☐ Feature
☐ Plugin
Are all requirements met?
☑︎ Code completed
☑︎ Smoke tested
☑︎ Unit tests added
☐ Code documentation added
☐ Any pending items have an associated Issue
Complete description
Because the interchange between protobuf and json casts ints to floats, this PR introduces a workaround to handle converting floats to integers by parsing the protobug struct_pb2.Value
with regex and inferring integers based on its __repr__
, which actually preserves the integer representation, e.g. number_value: 100
, but accessing the actual number_value
attribute will still return a float assert value.number_value == 100.0
.
See here in the protobuf codebase where ints and floats are treated the same.
Tracking Issue
flyteorg/flyte#3158
Follow-up issue
NA
flyteorg/flytekit
GitHub Actions: lint
GitHub Actions: docs
GitHub Actions: build-plugins (3.10, flytekit-vaex)
GitHub Actions: build-plugins (3.9, flytekit-whylogs)
GitHub Actions: build-plugins (3.9, flytekit-vaex)
GitHub Actions: build-plugins (3.9, flytekit-sqlalchemy)
GitHub Actions: build-plugins (3.9, flytekit-spark)
GitHub Actions: build-plugins (3.9, flytekit-snowflake)
GitHub Actions: build-plugins (3.9, flytekit-ray)
✅ 21 other checks have passed
21/30 successful checksGitHub
02/01/2023, 4:59 AMGitHub
02/01/2023, 7:37 AM<https://github.com/flyteorg/flytekit-java/tree/master|master>
by sonjaer
<https://github.com/flyteorg/flytekit-java/commit/19f013e1eac252fbba6e3c725f30817562a87974|19f013e1>
- Remove duplication of workflow inputs and outputs #minor (#180)
flyteorg/flytekit-javaGitHub
02/01/2023, 8:14 AM@AutoService(SdkWorkflow.class)
public class WelcomeWorkflow extends SdkWorkflow<WelcomeWorkflow.Input, WelcomeWorkflow.Output> {
@AutoValue
public abstract static class Input {
public abstract SdkBindingData<String> name();
public static WelcomeWorkflow.Input create(SdkBindingData<String> name) {
return new AutoValue_WelcomeWorkflow_Input(name);
}
}
@AutoValue
public abstract static class Output {
public abstract SdkBindingData<String> greeting();
public static WelcomeWorkflow.Output create(SdkBindingData<String> greeting) {
return new AutoValue_WelcomeWorkflow_Output(name);
}
}
public WelcomeWorkflow() {
super(
JacksonSdkType.of(WelcomeWorkflow.Input.class),
JacksonSdkType.of(WelcomeWorkflow.Output.class));
}
@Override
public void expand(SdkWorkflowBuilder builder) {
SdkBindingData<String> name = builder.inputOfString("name", "Name to be greeted");
SdkBindingData<String> greeting =
builder
.apply("greet", new GreetTask(), GreetTask.Input.create(name))
.getOutputs()
.greeting();
builder.output("greeting", greeting, "Welcome message");
}
}
After
@AutoService(SdkWorkflow.class)
public class WelcomeWorkflow extends SdkWorkflow<WelcomeWorkflow.Input, WelcomeWorkflow.Output> {
@AutoValue
public abstract static class Input {
@Description("Name to be greeted")
public abstract SdkBindingData<String> name();
public static WelcomeWorkflow.Input create(SdkBindingData<String> name) {
return new AutoValue_WelcomeWorkflow_Input(name);
}
}
@AutoValue
public abstract static class Output {
@Description("Welcome message")
public abstract SdkBindingData<String> greeting();
public static WelcomeWorkflow.Output create(SdkBindingData<String> greeting) {
return new AutoValue_WelcomeWorkflow_Output(name);
}
}
public WelcomeWorkflow() {
super(
JacksonSdkType.of(WelcomeWorkflow.Input.class),
JacksonSdkType.of(WelcomeWorkflow.Output.class));
}
@Override
public Output expand(SdkWorkflowBuilder builder, Input input) {
SdkBindingData<String> greeting =
builder
.apply("greet", new GreetTask(), GreetTask.Input.create(input.name()))
.getOutputs()
.greeting();
return Output.create(greeting);
}
}
Also there is the need to add descriptions to autovalue/case classes as the builder methods were the only place to set that up
flyteorg/flyteGitHub
02/01/2023, 8:28 AMSdkScalaType
search for it when reading the case classes fields
• When building the variable map it will set up the description or empty String if nothing was found
Tracking Issue
fixes flyteorg/flyte#3303
Follow-up issue
NA
flyteorg/flytekit-java
✅ All checks have passed
3/3 successful checksGitHub
02/01/2023, 2:42 PM<https://github.com/flyteorg/flytekit-java/tree/master|master>
by narape
<https://github.com/flyteorg/flytekit-java/commit/542ba84c2926cac074de3d43d724b80dba7821f5|542ba84c>
- Add description annotation for scala case classes (#183)
flyteorg/flytekit-javaGitHub
02/01/2023, 4:29 PMGitHub
02/01/2023, 4:49 PMGitHub
02/01/2023, 5:58 PM<https://github.com/flyteorg/flyteplugins/tree/master|master>
by hamersaw
<https://github.com/flyteorg/flyteplugins/commit/471a262a80b5e7cc01727a528ecc6f3f75d12c0b|471a262a>
- Discard fields when replica number equals zero to avoid api client error (#313)
flyteorg/flytepluginsGitHub
02/01/2023, 5:59 PMGitHub
02/01/2023, 7:15 PM