GitHub
01/29/2023, 7:16 AMbyhsu@byhsu-ld1 ~/local-repo/flyte/flyteplugins gh-tf-replica-bug* ❯ go test <http://github.com/flyteorg/flyteplugins/go/tasks/plugins/k8s/kfoperators/tensorflow|github.com/flyteorg/flyteplugins/go/tasks/plugins/k8s/kfoperators/tensorflow>
ok <http://github.com/flyteorg/flyteplugins/go/tasks/plugins/k8s/kfoperators/tensorflow|github.com/flyteorg/flyteplugins/go/tasks/plugins/k8s/kfoperators/tensorflow> 0.072s
Are all requirements met?
☑︎ Code completed
☐ Smoke tested
☑︎ Unit tests added
☑︎ Code documentation added
☐ Any pending items have an associated Issue
flyteorg/flyteplugins
✅ All checks have passed
6/6 successful checksGitHub
01/30/2023, 7:01 AMFile "/home/dev/conda_dev/devenv/Linux/envs/devenv-3.8-c/lib/python3.8/site-packages/flytekit/remote/remote.py", line 847, in execute
return self.execute_remote_task_lp(
File "/home/dev/conda_dev/devenv/Linux/envs/devenv-3.8-c/lib/python3.8/site-packages/flytekit/remote/remote.py", line 924, in execute_remote_task_lp
return self._execute(
File "/home/dev/conda_dev/devenv/Linux/envs/devenv-3.8-c/lib/python3.8/site-packages/flytekit/remote/remote.py", line 715, in _execute
type_hints[k] = TypeEngine.guess_python_type(input_flyte_type_map[k].type)
File "/home/dev/conda_dev/devenv/Linux/envs/devenv-3.8-c/lib/python3.8/site-packages/flytekit/core/type_engine.py", line 856, in guess_python_type
return transformer.guess_python_type(flyte_type)
File "/home/dev/conda_dev/devenv/Linux/envs/devenv-3.8-c/lib/python3.8/site-packages/flytekit/core/type_engine.py", line 1125, in guess_python_type
return typing.Union[tuple(TypeEngine.guess_python_type(v.type) for v in literal_type.union_type.variants)]
File "/home/dev/conda_dev/devenv/Linux/envs/devenv-3.8-c/lib/python3.8/site-packages/flytekit/core/type_engine.py", line 1125, in <genexpr>
return typing.Union[tuple(TypeEngine.guess_python_type(v.type) for v in literal_type.union_type.variants)]
AttributeError: 'LiteralType' object has no attribute 'type'
The fix seems to be changing v.type
-> v
Expected behavior
It should work!
Additional context to reproduce
No response
Screenshots
No response
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
01/30/2023, 1:27 PMExecutionNodeViews
page
• Moved childGroups fetch to onToggle
in Table and Timeline components - requests trigger when user clicked on expander
• Moved map tasks fetch to details page to back fill one-off nodeExecutions data, and to ReactFlowGraphComponent
to batch them for all known nodeExecutions, so the graph is rendered properly (this will slow down the graph tab, but based on user's feedback, it's ok, if graph tab takes some time to load).
Known issues
☐ some unit tests are broken
☑︎ add childGroups fetch in graph on node click
☐ fix rerender of graph on childGroups fetch
☑︎ fix compiledWorkflowClosure
to check for is_dynamic
field (available in node execution's metadata) instead of pulling multiple requests on repeat
☐ test filters in Table tab
☐ display parent node as nested
in graph to indicate it has children
Follow-up issue
NA
Test workflows
• normal core.control_flow.subworkflows.parent_wf
• dynamic <http://core.control_flow.dynamics.wf|core.control_flow.dynamics.wf>
• nested parent core.control_flow.subworkflows.nested_parent_wf
• map task <http://flyte.workflows.example_map_task.wf|flyte.workflows.example_map_task.wf>
flyteorg/flyteconsole
✅ All checks have passed
2/2 successful checksGitHub
01/30/2023, 2:20 PMworkflow_notifications
enabled produces broken configmap yaml for the region
parameter, thus admin and scheduler fails service deployment.
Eg:
notifications.yaml:
----
notifications:
type: aws
region:us-east-1
publisher:
Notice region:us-east-1
misses space after semicolon.
Expected behavior
Valid yaml should be produced by the helm chart.
Workaround add space in your region template values like so: region: " {{ .Values.userSettings.accountRegion }}"
Additional context to reproduce
1. Create test-values.yaml
userSettings:
accountRegion: us-east-1
accountNumber: 123123123
notifications:
topicName: topic-name
queueName: queue-name
workflow_notifications:
enabled: true
config:
notifications:
type: "aws"
region: "{{ .Values.userSettings.accountRegion }}"
publisher:
topicName: "arn:aws:sns:{{ .Values.userSettings.accountRegion }}:{{ .Values.userSettings.accountNumber }}:{{ .Values.userSettings.notifications.topicName }}"
processor:
queueName: "{{ .Values.userSettings.notifications.queueName }}"
accountId: "{{ .Values.userSettings.accountNumber }}"
emailer:
subject: "Flyte: {{ project }}/{{ domain }}/{{ launch_plan.name }} has '{{ phase }}'"
sender: "{{ .Values.userSettings.notifications.sender }}"
body: |
"Execution {{ workflow.project }}/{{ workflow.domain }}/{{ workflow.name }}/{{ name }} has {{ phase }}.
Details: [<https://flyte.example.com/console/projects/{{>](<https://flyte.example.com/console/projects/%7B%7B>) project }}/domains/{{ domain }}/executions/{{ name }}.
{{ error }}"
2. Run helm template admin flyteorg/flyte-core --version v1.2.1 --values test-values.yaml | grep -A 4 "notifications.yaml"
3. See:
notifications.yaml: |
notifications:
type: aws
region:us-east-1
publisher:
Which misses space after semicolon.
Screenshots
No response
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
01/30/2023, 2:42 PMGitHub
01/30/2023, 2:45 PM<https://github.com/flyteorg/flytesnacks/tree/master|master>
by ppiegaze
<https://github.com/flyteorg/flytesnacks/commit/e0dfa8c7ba561d0fb3adef71504a2015e4e14d60|e0dfa8c7>
- fix file name to enable appearance in left nav (#946)
flyteorg/flytesnacksGitHub
01/30/2023, 3:44 PM<https://github.com/flyteorg/flyteidl/tree/master|master>
by hamersaw
<https://github.com/flyteorg/flyteidl/commit/c60305cb0ced352cf3918f5e0e3de116271e0479|c60305cb>
- Added template configuration to task template (#358)
flyteorg/flyteidlGitHub
01/30/2023, 3:45 PMGitHub
01/30/2023, 3:45 PMGitHub
01/30/2023, 3:46 PMGitHub
01/30/2023, 5:00 PMGitHub
01/30/2023, 5:00 PMGitHub
01/30/2023, 5:00 PMGitHub
01/30/2023, 5:00 PMGitHub
01/30/2023, 5:15 PM<https://github.com/flyteorg/furo/tree/main|main>
by cosmicBboy
<https://github.com/flyteorg/furo/commit/b07786d27afe10bbbc8a8d402d50b65b9887ce78|b07786d2>
- update navbar
<https://github.com/flyteorg/furo/commit/4dfee7f34f6585564d98ab7226a35f3e63df8a55|4dfee7f3>
- update furo theme for new getting started section
<https://github.com/flyteorg/furo/commit/d18606ea3f2641a767467c22c7045169a3894ca5|d18606ea>
- update css for divs, dropdowns, tabs
<https://github.com/flyteorg/furo/commit/ab09ca68707199095efe2aa8cab824b88fe7beca|ab09ca68>
- update next/prev nav template
<https://github.com/flyteorg/furo/commit/714c0952f69c3cb8412c86381db1596b451e35a0|714c0952>
- Merge pull request #22 from flyteorg/getting-started
flyteorg/furoGitHub
01/30/2023, 5:15 PMGitHub
01/30/2023, 5:15 PM<https://github.com/flyteorg/flytesnacks/tree/master|master>
by cosmicBboy
<https://github.com/flyteorg/flytesnacks/commit/1e4c793dc97948d8178a71ff8eda008277ca0c41|1e4c793d>
- Revamp Getting Started Section in Flytesnacks (#944)
flyteorg/flytesnacksGitHub
01/30/2023, 5:22 PMGitHub
01/30/2023, 5:29 PM<https://github.com/flyteorg/furo/tree/main|main>
by cosmicBboy
<https://github.com/flyteorg/furo/commit/ed52a89f6f330135286300a338efdaa6aacd0058|ed52a89f>
- revert next/prev customization
flyteorg/furoGitHub
01/30/2023, 5:31 PMGitHub
01/30/2023, 5:31 PMGitHub
01/30/2023, 6:12 PMGitHub
01/30/2023, 6:13 PM<https://github.com/flyteorg/furo/tree/main|main>
by cosmicBboy
<https://github.com/flyteorg/furo/commit/e54e64a90fdc32b9a15552b402c86720da5cdf99|e54e64a9>
- Revert "update css styles for sphinx gallery"
flyteorg/furoGitHub
01/30/2023, 6:14 PMGitHub
01/30/2023, 6:29 PMGitHub
01/30/2023, 6:37 PM<https://github.com/flyteorg/furo/tree/main|main>
by cosmicBboy
<https://github.com/flyteorg/furo/commit/0939eea5ea4d4e2381aaf9a266e281070fc385b7|0939eea5>
- update styles
flyteorg/furoGitHub
01/30/2023, 6:38 PMGitHub
01/30/2023, 6:41 PM<https://github.com/flyteorg/furo/tree/main|main>
by cosmicBboy
<https://github.com/flyteorg/furo/commit/a1635a8fa257abe0e992ab4c1f892dc01362cd80|a1635a8f>
- update styles
flyteorg/furoGitHub
01/30/2023, 6:42 PMGitHub
01/30/2023, 6:50 PM