#313 Discard fields when replica number equals zero to avoid api client error Pull request opened by ByronHsu TL;DR In some versions of tensorflow CRD, there is an enforcement to restrict the minimum number of replica. If users pass in 0 as the number of replicas, the k8s client will throw an error at runtime. The field should be discarded if the number of replicas is zero. Type ☑︎ Bug Fix ☐ Feature ☐ Plugin Bug In the order version of tfjob CRD, it will validate the minimum number of replicas. If the replica == 0 but the field exists, the kubeflow client will fail. Test

byhsu@byhsu-ld1 ~/local-repo/flyte/flyteplugins gh-tf-replica-bug* ❯ go test <http://github.com/flyteorg/flyteplugins/go/tasks/plugins/k8s/kfoperators/tensorflow|github.com/flyteorg/flyteplugins/go/tasks/plugins/k8s/kfoperators/tensorflow>
ok      <http://github.com/flyteorg/flyteplugins/go/tasks/plugins/k8s/kfoperators/tensorflow|github.com/flyteorg/flyteplugins/go/tasks/plugins/k8s/kfoperators/tensorflow>    0.072s

Are all requirements met? ☑︎ Code completed ☐ Smoke tested ☑︎ Unit tests added ☑︎ Code documentation added ☐ Any pending items have an associated Issue flyteorg/flyteplugins ✅ All checks have passed 6/6 successful checks

#3294 [BUG] Bug in Union Type guessing for flyte remote Issue created by kumare3 Describe the bug Hi team, it appear that there a bug in flytekit on this line: https://github.com/flyteorg/flytekit/blob/master/flytekit/core/type_engine.py#L1141 When executing a task with Union-typed parameters using FlyteRemote, the above-mentioned line raises an Exception:

File "/home/dev/conda_dev/devenv/Linux/envs/devenv-3.8-c/lib/python3.8/site-packages/flytekit/remote/remote.py", line 847, in execute
    return self.execute_remote_task_lp(
  File "/home/dev/conda_dev/devenv/Linux/envs/devenv-3.8-c/lib/python3.8/site-packages/flytekit/remote/remote.py", line 924, in execute_remote_task_lp
    return self._execute(
  File "/home/dev/conda_dev/devenv/Linux/envs/devenv-3.8-c/lib/python3.8/site-packages/flytekit/remote/remote.py", line 715, in _execute
    type_hints[k] = TypeEngine.guess_python_type(input_flyte_type_map[k].type)
  File "/home/dev/conda_dev/devenv/Linux/envs/devenv-3.8-c/lib/python3.8/site-packages/flytekit/core/type_engine.py", line 856, in guess_python_type
    return transformer.guess_python_type(flyte_type)
  File "/home/dev/conda_dev/devenv/Linux/envs/devenv-3.8-c/lib/python3.8/site-packages/flytekit/core/type_engine.py", line 1125, in guess_python_type
    return typing.Union[tuple(TypeEngine.guess_python_type(v.type) for v in literal_type.union_type.variants)]
  File "/home/dev/conda_dev/devenv/Linux/envs/devenv-3.8-c/lib/python3.8/site-packages/flytekit/core/type_engine.py", line 1125, in <genexpr>
    return typing.Union[tuple(TypeEngine.guess_python_type(v.type) for v in literal_type.union_type.variants)]
AttributeError: 'LiteralType' object has no attribute 'type'

The fix seems to be changing

v.type

->

v

Expected behavior It should work! Additional context to reproduce No response Screenshots No response Are you sure this issue hasn't been raised already? ☑︎ Yes Have you read the Code of Conduct? ☑︎ Yes flyteorg/flyte

#649 fix: transition to nodeExecutionById context with update Pull request opened by olga-union on <!date^1671036288^{date_short}|2022-12-14T16:44:48Z> Signed-off-by: Olga Nad olga@union.ai TL;DR Replaced recursive task execution fetch logic with on demand to avoid front-loading ExecutionNodeViews component with inner layer requests, which significantly slow down page render for big workflows. Type ☐ Bug Fix ☐ Feature ☐ Plugin ☑︎ Chore Are all requirements met? ☐ Code completed ☐ Smoke tested ☐ Unit tests added ☐ Code documentation added ☐ Any pending items have an associated Issue Complete description • Removed childGroups fetch (recursive) from

ExecutionNodeViews

page • Moved childGroups fetch to

onToggle

in Table and Timeline components - requests trigger when user clicked on expander • Moved map tasks fetch to details page to back fill one-off nodeExecutions data, and to

ReactFlowGraphComponent

to batch them for all known nodeExecutions, so the graph is rendered properly (this will slow down the graph tab, but based on user's feedback, it's ok, if graph tab takes some time to load). Known issues ☐ some unit tests are broken ☑︎ add childGroups fetch in graph on node click ☐ fix rerender of graph on childGroups fetch ☑︎ fix

compiledWorkflowClosure

to check for

is_dynamic

field (available in node execution's metadata) instead of pulling multiple requests on repeat ☐ test filters in Table tab ☐ display parent node as

nested

in graph to indicate it has children Follow-up issue NA Test workflows • normal

core.control_flow.subworkflows.parent_wf

• dynamic

<http://core.control_flow.dynamics.wf|core.control_flow.dynamics.wf>

• nested parent

core.control_flow.subworkflows.nested_parent_wf

• map task

<http://flyte.workflows.example_map_task.wf|flyte.workflows.example_map_task.wf>

flyteorg/flyteconsole ✅ All checks have passed 2/2 successful checks

#3296 [BUG] Helm chart handles workflow_notifications region incorrectly Issue created by andrusha Describe the bug Applying helm chart with

workflow_notifications

enabled produces broken configmap yaml for the

region

parameter, thus admin and scheduler fails service deployment. Eg:

notifications.yaml:
----
notifications:
  type: aws
  region:us-east-1
  publisher:

Notice

region:us-east-1

misses space after semicolon. Expected behavior Valid yaml should be produced by the helm chart. Workaround add space in your region template values like so:

region: " {{ .Values.userSettings.accountRegion }}"

Additional context to reproduce 1. Create

test-values.yaml

userSettings:
  accountRegion: us-east-1
  accountNumber: 123123123
  notifications:
    topicName: topic-name
    queueName: queue-name

workflow_notifications:
  enabled: true
  config:
    notifications:
      type: "aws"
      region: "{{ .Values.userSettings.accountRegion }}"
      publisher:
        topicName: "arn:aws:sns:{{ .Values.userSettings.accountRegion }}:{{ .Values.userSettings.accountNumber }}:{{ .Values.userSettings.notifications.topicName }}"
      processor:
        queueName: "{{ .Values.userSettings.notifications.queueName }}"
        accountId: "{{ .Values.userSettings.accountNumber }}"
      emailer:
        subject: "Flyte: {{ project }}/{{ domain }}/{{ launch_plan.name }} has '{{ phase }}'"
        sender: "{{ .Values.userSettings.notifications.sender }}"
        body: |
          "Execution {{ workflow.project }}/{{ workflow.domain }}/{{ workflow.name }}/{{ name }} has {{ phase }}.
           Details: [<https://flyte.example.com/console/projects/{{>](<https://flyte.example.com/console/projects/%7B%7B>) project }}/domains/{{ domain }}/executions/{{ name }}.
           {{ error }}"

2. Run

helm template admin flyteorg/flyte-core --version v1.2.1 --values test-values.yaml | grep -A 4 "notifications.yaml"

3. See:

notifications.yaml: |
    notifications:
      type: aws
      region:us-east-1
      publisher:

Which misses space after semicolon. Screenshots No response Are you sure this issue hasn't been raised already? ☑︎ Yes Have you read the Code of Conduct? ☑︎ Yes flyteorg/flyte

#181 Test master build Pull request opened by sonjaer on <!date^1675088533^{date_short}|2023-01-30T14:22:13Z> Read then delete this section - Make sure to use a concise title for the pull-request. _- Use #patch, #minor or #major in the pull-request title to bump the corresponding version. Otherwise, the patch version will be bumped. More details_ TL;DR Please replace this text with a description of what this PR accomplishes. Type ☐ Bug Fix ☐ Feature ☐ Plugin Are all requirements met? ☐ Code completed ☐ Smoke tested ☐ Unit tests added ☐ Code documentation added ☐ Any pending items have an associated Issue Complete description How did you fix the bug, make the feature etc. Link to any design docs etc Tracking Issue _Remove the '_fixes_' keyword if there will be multiple PRs to fix the linked issue_ fixes https://github.com/flyteorg/flyte/issues/ Follow-up issue NA OR https://github.com/flyteorg/flyte/issues/ flyteorg/flytekit-java GitHub Actions: build-snapshot DCO: DCO ✅ 1 other check has passed 1/3 successful checks

1 new commit pushed to

<https://github.com/flyteorg/flytesnacks/tree/master|master>

by ppiegaze

<https://github.com/flyteorg/flytesnacks/commit/e0dfa8c7ba561d0fb3adef71504a2015e4e14d60|e0dfa8c7>

- fix file name to enable appearance in left nav (#946) flyteorg/flytesnacks

1 new commit pushed to

<https://github.com/flyteorg/flyteidl/tree/master|master>

by hamersaw

<https://github.com/flyteorg/flyteidl/commit/c60305cb0ced352cf3918f5e0e3de116271e0479|c60305cb>

- Added template configuration to task template (#358) flyteorg/flyteidl

Release - flytesnacks v0.3.162 New release published by flyte-bot Changelog • e0dfa8c fix file name to enable appearance in left nav (#946) flyteorg/flytesnacks

Release - v1.3.5 New release published by flyte-bot Changelog • c60305c Added template configuration to task template (#358) flyteorg/flyteidl

#522 Update flyteidl version Pull request opened by flyte-bot Update flyteidl version • Auto-generated by [flyte-bot] flyteorg/flytepropeller GitHub Actions: Build & Push Flytepropeller Image GitHub Actions: Goreleaser GitHub Actions: Bump Version ✅ 11 other checks have passed 11/14 successful checks

Pending review on flyteorg/flyteidl - Manage reminder [#297] Proposal : Settings proto (pmahindrakar-oss) a month stale · 9 months old · Waiting on _ @Haytham Abuelfutuh, katrogan_

Pending review on flyteorg/flytekit-java - Manage reminder [#6] Update .env.local in README (kanterov) 9 months stale · 3 years old · Waiting on _ @Ketan (kumare3)_

Pending review on flyteorg/flyteplugins - Manage reminder [#300] sending correct external resources for k8s-array plugin (hamersaw) a month stale · 2 months old · Waiting on _ @Haytham Abuelfutuh, @Ketan (kumare3), pingsutw_ [#310] Transition to failed state if the task cannot be created (pingsutw) 2 hours stale · 10 days old · Waiting on _ hamersaw_

[#1418] Deprecate FlyteSchema (pingsutw) 2 hours stale · 7 days old · Waiting on _ @Niels Bantilan, @Yee, @Ketan (kumare3)_

5 new commits pushed to

<https://github.com/flyteorg/furo/tree/main|main>

by cosmicBboy

<https://github.com/flyteorg/furo/commit/b07786d27afe10bbbc8a8d402d50b65b9887ce78|b07786d2>

- update navbar

<https://github.com/flyteorg/furo/commit/4dfee7f34f6585564d98ab7226a35f3e63df8a55|4dfee7f3>

- update furo theme for new getting started section

<https://github.com/flyteorg/furo/commit/d18606ea3f2641a767467c22c7045169a3894ca5|d18606ea>

- update css for divs, dropdowns, tabs

<https://github.com/flyteorg/furo/commit/ab09ca68707199095efe2aa8cab824b88fe7beca|ab09ca68>

- update next/prev nav template

<https://github.com/flyteorg/furo/commit/714c0952f69c3cb8412c86381db1596b451e35a0|714c0952>

- Merge pull request #22 from flyteorg/getting-started flyteorg/furo

#22 Update theme for new getting started section on flytesnacks Pull request opened by cosmicBboy • updates the top nav header • minor update on theme css • modify page template for custom next/prev page setting flyteorg/furo ✅ All checks have passed 2/2 successful checks

1 new commit pushed to

<https://github.com/flyteorg/flytesnacks/tree/master|master>

by cosmicBboy

<https://github.com/flyteorg/flytesnacks/commit/1e4c793dc97948d8178a71ff8eda008277ca0c41|1e4c793d>

- Revamp Getting Started Section in Flytesnacks (#944) flyteorg/flytesnacks

Deployment to github-pages by github-pages[bot] flyteorg/furo

1 new commit pushed to

<https://github.com/flyteorg/furo/tree/main|main>

by cosmicBboy

<https://github.com/flyteorg/furo/commit/ed52a89f6f330135286300a338efdaa6aacd0058|ed52a89f>

- revert next/prev customization flyteorg/furo

#947 Add README.rst for docs Pull request opened by ppiegaze Signed-off-by: Peeter Piegaze peeter@union.ai flyteorg/flytesnacks GitHub Actions: Mark github pre-release as Release GitHub Actions: Publish artifacts to github release GitHub Actions: Create Prerelease GitHub Actions: Bump Version ✅ 26 other checks have passed 26/30 successful checks

Deployment to github-pages by github-pages[bot] flyteorg/furo

Release - flytesnacks v0.3.163 New release published by flyte-bot Changelog • 1e4c793 Revamp Getting Started Section in Flytesnacks (#944) flyteorg/flytesnacks

1 new commit pushed to

<https://github.com/flyteorg/furo/tree/main|main>

by cosmicBboy

<https://github.com/flyteorg/furo/commit/e54e64a90fdc32b9a15552b402c86720da5cdf99|e54e64a9>

- Revert "update css styles for sphinx gallery" flyteorg/furo

Deployment to github-pages by github-pages[bot] flyteorg/furo

#3297 Fixed notification region config Pull request opened by pmahindrakar-oss Signed-off-by: pmahindrakar-oss prafulla.mahindrakar@gmail.com Tracking issue fixes #3296 Tested it and it generates the right region config with indentation Describe your changes [x] - Correct; marked as done [X] - Correct; marked as done [ ] - Not correct; marked as not done Check all the applicable boxes ☐ I updated the documentation accordingly. ☐ All new and existing tests passed. ☐ All commits are signed-off. Screenshots Note to reviewers flyteorg/flyte ✅ All checks have passed 9/9 successful checks

1 new commit pushed to

<https://github.com/flyteorg/furo/tree/main|main>

by cosmicBboy

<https://github.com/flyteorg/furo/commit/0939eea5ea4d4e2381aaf9a266e281070fc385b7|0939eea5>

- update styles flyteorg/furo

Deployment to github-pages by github-pages[bot] flyteorg/furo

1 new commit pushed to

<https://github.com/flyteorg/furo/tree/main|main>

by cosmicBboy

<https://github.com/flyteorg/furo/commit/a1635a8fa257abe0e992ab4c1f892dc01362cd80|a1635a8f>

- update styles flyteorg/furo

Deployment to github-pages by github-pages[bot] flyteorg/furo

#3298 remove getting started Pull request opened by cosmicBboy Signed-off-by: Niels Bantilan niels.bantilan@gmail.com This PR removes the old getting started in favor of the one in flytesnacks Tracking issue Describe your changes Check all the applicable boxes ☐ I updated the documentation accordingly. ☐ All new and existing tests passed. ☐ All commits are signed-off. Screenshots Note to reviewers flyteorg/flyte ✅ All checks have passed 6/6 successful checks