GitHub
10/01/2023, 5:09 PMGitHub
10/01/2023, 5:14 PMGitHub
10/01/2023, 5:21 PMGitHub
10/02/2023, 12:52 AM$ flytectl get project
--------------- --------------- ---------------------------
| ID | NAME | DESCRIPTION |
--------------- --------------- ---------------------------
| flyteexamples | flyteexamples | flyteexamples description |
--------------- --------------- ---------------------------
| flytetester | flytetester | flytetester description |
--------------- --------------- ---------------------------
| flytesnacks | woopidoo | oops2 |
--------------- --------------- ---------------------------
3 rows
$ flytectl update project --id flytesnacks --archive
Project flytesnacks updated
$ flytectl get project
--------------- --------------- ---------------------------
| ID | NAME | DESCRIPTION |
--------------- --------------- ---------------------------
| flyteexamples | flyteexamples | flyteexamples description |
--------------- --------------- ---------------------------
| flytetester | flytetester | flytetester description |
--------------- --------------- ---------------------------
2 rows
$ flytectl update project --id flytesnacks --description "bananas"
Project flytesnacks updated
$ flytectl get project
--------------- --------------- ---------------------------
| ID | NAME | DESCRIPTION |
--------------- --------------- ---------------------------
| flyteexamples | flyteexamples | flyteexamples description |
--------------- --------------- ---------------------------
| flytetester | flytetester | flytetester description |
--------------- --------------- ---------------------------
| flytesnacks | woopidoo | bananas |
--------------- --------------- ---------------------------
3 rows
Expected behavior
Objects should stay in whatever state they were prior to update.
Additional context to reproduce
1. Archive an object.
2. Update any property except state (e.g., do not use --activate
or --archive
flags).
3. Get the object and see that its state changed to active.
Screenshots
No response
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteGitHub
10/02/2023, 4:58 AM*ResourceWrapper
cache (*Resource) -> cast to (*Resource) // it works
s3 (Resource) -> cast to (*Resource) // Failed to do type casting since we unmarshall the resource to Resource
here.
We read the resource from s3 bucket after restarting the propeller (cache becomes empty).
Type
☑︎ Bug Fix
☐ Feature
☐ Plugin
Are all requirements met?
☑︎ Code completed
☑︎ Smoke tested
☑︎ Unit tests added
☐ Code documentation added
☐ Any pending items have an associated Issue
Complete description
^^^
Tracking Issue
NA
Follow-up issue
NA
flyteorg/flyte
GitHub Actions: Build & Push Image
GitHub Actions: Bump git tags
✅ 28 other checks have passed
28/30 successful checksGitHub
10/02/2023, 8:25 AMGitHub
10/02/2023, 8:35 AM<https://github.com/flyteorg/flytekit-java/tree/master|master>
by andresgomezfrr
<https://github.com/flyteorg/flytekit-java/commit/66efab89623c7446116fca0b351367ffbd2685d2|66efab89>
- Fetch task template in dynamic workflow task (#254)
flyteorg/flytekit-javaGitHub
10/02/2023, 9:09 AM<https://github.com/flyteorg/flytekit-java/tree/master|master>
by github-actions[bot]
<https://github.com/flyteorg/flytekit-java/commit/89ee5d7de5498d8094960b425a6708b40ec4fab3|89ee5d7d>
- [maven-release-plugin] prepare release 0.4.26
flyteorg/flytekit-javaGitHub
10/02/2023, 9:09 AM<https://github.com/flyteorg/flytekit-java/tree/master|master>
by github-actions[bot]
<https://github.com/flyteorg/flytekit-java/commit/c892cebfae2d713d736d2ca5b8829bd73b18c477|c892cebf>
- [maven-release-plugin] prepare for next development iteration
flyteorg/flytekit-javaGitHub
10/02/2023, 10:10 AMGitHub
10/02/2023, 10:59 AMApplyResourceOverrides
function to ensure that user-specified resource requests and limits are respected without being overridden by default values, except when explicitly requested. Here are the key changes I made:
1. Introduced a new flag assignIfUnset
to control whether default values should be assigned. This flag is used to determine whether the code should apply default values for resources.
2. Modified the behavior inside the function to check the assignIfUnset
flag before applying default values. When assignIfUnset
is set to true
, default values will be assigned only if the user hasn't already specified resource requests and limits.
3. Added conditional checks for each resource type (e.g., CPU, memory, ephemeral storage, GPU) to ensure that the default values are applied only if the user has not already set resource requirements.
4. Removed the assignment of default values for storage resources (v1.ResourceStorage
) based on the flag assignIfUnset
. This allows users to set their own storage requirements without being overridden by defaults.
5. Introduced the shouldAdjustGPU
flag to determine whether GPU resource adjustments are necessary. GPU resources are now adjusted based on user-specified values, and the gpuResourceName
is used for customization.
6. Updated the comments to reflect the changes made and provide context for the assignIfUnset
flag and resource adjustments.
These changes ensure that users can set their desired resource requirements, and the code will respect their choices without applying default values unless explicitly requested by setting assignIfUnset
to true
. This provides greater flexibility and control to users when specifying resource requirements for their tasks.
Check all the applicable boxes
☐ I updated the documentation accordingly.
☑︎ All new and existing tests passed.
☑︎ All commits are signed-off.
Note to reviewers
@samhita-alla
As per your instruction, I have created the Pull Request.
I kindly request you to review it at your earliest convenience.
flyteorg/flyte
GitHub Actions: Build & Push Image
GitHub Actions: Bump git tags
Codecov: 57.68% (-1.30%) compared to b35cc95
GitHub Actions: Unit Tests (flyteplugins) / Run Unit Test
GitHub Actions: Lint (flyteplugins) / Run Lint
✅ 25 other checks have passed
25/30 successful checksGitHub
10/02/2023, 4:01 PMGitHub
10/02/2023, 4:01 PMGitHub
10/02/2023, 4:01 PMGitHub
10/02/2023, 5:23 PMtestutils.TearDownAndVerify
is being used by several tests to verify that standard output contains certain strings. Currently, it always fails to read from the incorrect stream, and swallows the error. It never fails.
The fix uncovered two failing tests, which this PR also fixes.
Type
☑︎ Bug Fix
☐ Feature
☐ Plugin
Are all requirements met?
☑︎ Code completed
☐ Smoke tested
☑︎ Unit tests added
☐ Code documentation added
☐ Any pending items have an associated Issue
Complete description
`testutils.TearDownAndVerify`:
• close the writer and read from the reader to actually verify correctness of the output in tests
• stop swallowing errors
Tracking Issue
None.
Follow-up issue
NA
flyteorg/flytectl
GitHub Actions: Generate documentation
GitHub Actions: Goreleaser
GitHub Actions: Bump Version
✅ 9 other checks have passed
9/12 successful checksGitHub
10/02/2023, 5:45 PMauthor
and author_email
.
flyteorg/flytekit
Codecov: 54.97% (-0.03%) compared to 2f7073d
✅ 29 other checks have passed
29/30 successful checksGitHub
10/02/2023, 6:10 PM--force
flag.
Type
☐ Bug Fix
☑︎ Feature
☐ Plugin
Are all requirements met?
☑︎ Code completed
☑︎ Smoke tested
☑︎ Unit tests added
☑︎ Code documentation added
☑︎ Any pending items have an associated Issue
Complete description
Examples:
> flytectl update project --id flytesnacks --name "what a great name" --archive
The following changes are to be applied.
--- before
+++ after
@@ -8,5 +8,6 @@
name: production
id: flytesnacks
labels: {}
-name: woopidoo2
+name: what a great name
+state: 1
Continue? [y/n]: y
project flytesnacks updated
> flytectl update project --id flytesnacks --description "hello apples" --activate --force
The following changes are to be applied.
--- before
+++ after
@@ -1,4 +1,4 @@
-description: bananas
+description: hello apples
domains:
- id: development
name: development
@@ -9,5 +9,4 @@
id: flytesnacks
labels: {}
name: what a great name
-state: 1
project flytesnacks updated
> flytectl update task-resource-attribute --attrFile ~/t/task-resource-attributes.yaml
The following changes are to be applied.
--- before
+++ after
@@ -1,4 +1,8 @@
TaskResourceAttributes:
- limits:
+ defaults:
cpu: "3"
+ memory: 150Mi
+ limits:
+ cpu: "2"
+ memory: 450Mi
Continue? [y/n]: n
Error: update aborted by user
> flytectl update task-resource-attribute --attrFile ~/t/task-resource-attributes.yaml
No changes detected. Skipping the update.
Tracking Issue
flyteorg/flyte#3986
Follow-up issue
NA
flyteorg/flytectl
GitHub Actions: Goreleaser
GitHub Actions: Generate documentation
GitHub Actions: Bump Version
✅ 9 other checks have passed
9/12 successful checksGitHub
10/02/2023, 7:25 PM<https://github.com/flyteorg/flytekit/tree/master|master>
by pingsutw
<https://github.com/flyteorg/flytekit/commit/4b06628e61263ef52a9a3c31286b9bb09121fcfe|4b06628e>
- modified setup.py in flytekit-mmcloud (#1864)
flyteorg/flytekitGitHub
10/02/2023, 7:44 PMitemID
to it. The workers won't process the item again after the task is done.
Before:
After:
100 workflows, each has 100 tasks.
Before:
image▾
image▾
GitHub
10/02/2023, 8:48 PM<https://github.com/flyteorg/flytesnacks/tree/master|master>
by cosmicBboy
<https://github.com/flyteorg/flytesnacks/commit/fe4968d398290486e370967b87fa550d004ce991|fe4968d3>
- MemVerge MMCloud Agent (#1128)
flyteorg/flytesnacksGitHub
10/02/2023, 8:57 PMGitHub
10/02/2023, 9:00 PMGitHub
10/02/2023, 9:15 PM1.11.1 / 2022-02-15
• [SECURITY FIX] promhttp: Check validity of method and code label values prometheus/client_golang#987 (Addressed `CVE-2022-21698`)
What's Changed
• promhttp: Check validity of method and code label values by `@bwplotka` and `@kakkoyun` in prometheus/client_golang#987
Full Changelog: prometheus/client_golang@v1.11.0...v1.11.1
v1.11.0 / 2021-06-07
• [CHANGE] Add new collectors package. #862
• [CHANGE]is deprecated, useprometheus.NewExpvarCollector
instead. #862collectors.NewExpvarCollector
• [CHANGE]is deprecated, useprometheus.NewGoCollector
instead. #862collectors.NewGoCollector
• [CHANGE]is deprecated, useprometheus.NewBuildInfoCollector
instead. #862collectors.NewBuildInfoCollector
• [FEATURE] Add new collector for database/sql#DBStats. #866
• [FEATURE] API client: Add exemplars API support. #861
• [ENHANCEMENT] API client: Add newer fields to Rules API. #855
• [ENHANCEMENT] API client: Add missing fields to Targets API. #856
What's Changed
• Synchronize common files from prometheus/prometheus by `@prombot` in prometheus/client_golang#846
• Synchronize common files from prometheus/prometheus by `@prombot` in prometheus/client_golang#849
• Synchronize common files from prometheus/prometheus by `@prombot` in prometheus/client_golang#853
• Add newer fields to Rules API by `@gouthamve` in prometheus/client_golang#855
• Add missing fields to targets API by `@yeya24` in prometheus/client_golang#856
• Synchronize common files from prometheus/prometheus by `@prombot` in prometheus/client_golang#857
• Add exemplars API support by `@yeya24` in prometheus/client_golang#861
• Improve description of MaxAge in summary docs by `@Dean-Coakley` in prometheus/client_golang#864
• Add new collectors package by `@johejo` in prometheus/client_golang#862
• Add collector for database/sql#DBStats by `@johejo` in prometheus/client_golang#866
• Make dbStatsCollector more DRY by `@beorn7` in prometheus/client_golang#867
• Change maintainers from `@beorn7` to @bwplotka/`@kakkoyun` by `@beorn7` in prometheus/client_golang#873
• Document implications of negative observations by `@beorn7` in prometheus/client_golang#871
• Update Go modules by `@SuperQ` in prometheus/client_golang#875
New Contributors
• `@gouthamve` made their first contribution in prometheus/client_golang#855
Full Changelog: prometheus/client_golang@v1.10.0...v1.11.0
1.10.0 / 2021-03-18
• [CHANGE] Minimum required Go version is now 1.13.
• [CHANGE] API client: Add matchers toandLabelNames
. #828LabesValues
• [FEATURE] API client: Add buildinfo call. #841
• [BUGFIX] Fix build on riscv64. #833
What's Changed
• Add SECURITY.md by `@roidelapluie` in prometheus/client_golang#831
• Bump prometheus/procfs to 0.3.0 to fix building on riscv64 by `@zhsj` in prometheus/client_golang#833
• Fix typo in comments in prometheus/client_golang#835... (truncated) Changelog _Sourced from github.com/prometheus/client_golang's changelog._
Unreleased
1.14.0 / 2022-11-08
• [FEATURE] Add Support for Native Histograms. #1150
• [CHANGE] Extendto implementprometheus.Registry
interface. #1103prometheus.Collector
1.13.1 / 2022-11-01
• [BUGFIX] Fix race condition with Exemplar in Counter. #1146
• [BUGFIX] Fixvalue ofCumulativeCount
bucket created from exemplar. #1148+Inf
• [BUGFIX] Fix double-counting bug in. #1118promhttp.InstrumentRoundTripperCounter
1.13.0 / 2022-08-05
• [CHANGE] Minimum required Go version is now 1.17 (we also test client_golang against new 1.19 version).
• [ENHANCEMENT] Addedflyteorg/flyte GitHub Actions: Build & Push Image GitHub Actions: Bump git tags GitHub Actions: Integration Test GitHub Actions: Lint GitHub Actions: Unit Tests GitHub Actions: Check Go Generate GitHub Actions: Docker Build Images (flytecopilot) / build_docker GitHub Actions: Docker Build Images (flytepropeller) / build_docker GitHub Actions: Docker Build Images (datacatalog) / build_docker GitHub Actions: Docker Build Images (flyteadmin) / build_docker GitHub Actions: generate_helm GitHub Actions: publish-development-helm-chart (flyteagent) GitHub Actions: docs GitHub Actions: publish-development-helm-chart (flyte-core) GitHub Actions: compile GitHub Actions: unpack-envvars GitHub Actions: publish-development-helm-chart (flyte-binary) GitHub Actions: Check for spelling errors GitHub Actions: generate_kustomize DCO: DCO ✅ 1 other check has passed 1/21 successful checksinterface forprometheus.TransactionalGatherer
use which allows using low allocation update techniques for custom colle…promhttp.Handler
GitHub
10/02/2023, 9:15 PM<https://github.com/flyteorg/community/tree/main|main>
by davidmirror-ops
<https://github.com/flyteorg/community/commit/1a05fcf5c874c89bdb2ae996b665c7270e81a81e|1a05fcf5>
- Update community meeting notes
flyteorg/communityGitHub
10/02/2023, 9:28 PMGitHub
10/02/2023, 9:30 PMGitHub
10/02/2023, 9:34 PMGitHub
10/02/2023, 9:46 PMGitHub
10/02/2023, 10:12 PM<https://github.com/flyteorg/flytekit/tree/master|master>
by pingsutw
<https://github.com/flyteorg/flytekit/commit/11e98fbac998fc2d396b8b4728e9adfd2e2297e1|11e98fba>
- Label request_failure metric with error_code (#1862)
flyteorg/flytekitGitHub
10/02/2023, 11:11 PM